Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plot.tune documentation contains two plot.tune.splsda methods #189

Closed
Max-Bladen opened this issue Mar 15, 2022 · 0 comments · Fixed by #190
Closed

plot.tune documentation contains two plot.tune.splsda methods #189

Max-Bladen opened this issue Mar 15, 2022 · 0 comments · Fixed by #190
Assignees
@Max-Bladen
Labels
bug Something isn't working documentation related to documentation refactorisation For improvements to the package which don't change functionality, just improve backend structure

Comments

@Max-Bladen
Copy link
Collaborator

Within the documentation for the plot.tune() function, there are two methods which describe the plot.tune.splsda() function. In the S3methods-plot.tune.R file, there is the original plot.tune.splsda(). However, there is also the plot.tune.spls1() function. After plot.tune.splsda() is defined, it is set to:

plot.tune.splsda <- plot.tune.spls1 (line 648).

Upon brief exploration, the plot.tune.splsda() function is not used. This will be explored further and confirmed. If so, then potentially removing the original plot.tune.splsda() will be for the best.
@Max-Bladen Max-Bladen added bug Something isn't working wip work-in-progress documentation related to documentation refactorisation For improvements to the package which don't change functionality, just improve backend structure labels Mar 15, 2022
@Max-Bladen Max-Bladen self-assigned this Mar 15, 2022
@Max-Bladen Max-Bladen linked a pull request Mar 15, 2022 that will close this issue
Fix for Issue #189 #190
Merged
@Max-Bladen Max-Bladen removed the wip work-in-progress label Mar 15, 2022
Max-Bladen added a commit that referenced this issue Apr 4, 2022
@Max-Bladen
Fix for #189. Doc Commit
37d94d9 
docs(plot.tune): updated the `.Rd` files so that the `sd` parameter has the correct default values (`NULL`, not `TRUE`)
@Max-Bladen Max-Bladen added rapid-review for PRs which will take minimal time to review and close ready-to-review for all PRs that are ready to be reviewed. including complex, larger commits labels Aug 1, 2022
Max-Bladen added a commit that referenced this issue Sep 26, 2022
@Max-Bladen
Fix for Issue #189 (#190)
970e8a9 
refactor: removed depreciated `plot.tune.splsda()`. Reduces package clutter and document repetition
@Max-Bladen Max-Bladen removed rapid-review for PRs which will take minimal time to review and close ready-to-review for all PRs that are ready to be reviewed. including complex, larger commits labels Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Max-Bladen Max-Bladen

Labels
bug Something isn't working documentation related to documentation refactorisation For improvements to the package which don't change functionality, just improve backend structure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for Issue #189 mixOmicsTeam/mixOmics
1 participant
@Max-Bladen