Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings in package tests #270

Closed
Max-Bladen opened this issue Nov 16, 2022 · 0 comments · Fixed by #271
Closed

Warnings in package tests #270

Max-Bladen opened this issue Nov 16, 2022 · 0 comments · Fixed by #271
Assignees
@Max-Bladen
Labels
bug Something isn't working

Comments

@Max-Bladen
Copy link
Collaborator

🐞 Describe the bug:

Running the package tests generate two warnings, as follows:

Warning (test-auroc.R:15): auroc works
Using `size` aesthetic for lines was deprecated in ggplot2 3.4.0.
ℹ Please use `linewidth` instead.

and

Warning (test-plotIndiv.R:166): plotIndiv.sgccda(..., blocks = 'average') works with ellipse=TRUE
`aes_string()` was deprecated in ggplot2 3.0.0.
ℹ Please use tidy evaluation ideoms with `aes()`

🤔 Expected behavior:
No errors or warnings should show

💡 Possible solution:
Adjust the depreciated calls via ggplot2
@Max-Bladen Max-Bladen added the bug Something isn't working label Nov 16, 2022
@Max-Bladen Max-Bladen assigned aljabadi and Max-Bladen and unassigned aljabadi Nov 16, 2022
@Max-Bladen Max-Bladen added the wip work-in-progress label Nov 16, 2022
Max-Bladen added a commit that referenced this issue Nov 16, 2022
@Max-Bladen
Fix for Issue #270
22a9e01 
fix: changed the depreciated `size` parameter to `linewidth` and changed `aes_string()` to `aes()`
Max-Bladen added a commit that referenced this issue Nov 16, 2022
@Max-Bladen
Fix for Issue #270
d03bbde 
fix: additional `aes_string()` call changed to `aes()`
Max-Bladen added a commit that referenced this issue Nov 16, 2022
@Max-Bladen
Fix for Issue #270
28b3914 
fix: changing `aes_string()` to `aes()` introduced error. Adjusted `geom_path` calls so X and Y vectors are appropriately set
@Max-Bladen Max-Bladen linked a pull request Nov 17, 2022 that will close this issue
Fix for Issue #270 #271
Merged
Max-Bladen added a commit that referenced this issue Nov 17, 2022
@Max-Bladen
Fix for Issue #270
98763bd 
refactor: removed some commented lines
Max-Bladen added a commit that referenced this issue Nov 17, 2022
@Max-Bladen
Fix for Issue #270
89bbaa7 
tests: added test for `plotIndiv.mint.plsda()` with `ellipse = TRUE`
Max-Bladen added a commit that referenced this issue Nov 22, 2022
@Max-Bladen
Fix for Issue #270 (#271)
7427868 
fix: changed the depreciated `size` parameter to `linewidth` and changed `aes_string()` to `aes()`

fix: additional `aes_string()` call changed to `aes()`

fix: changing `aes_string()` to `aes()` introduced error. Adjusted `geom_path` calls so X and Y vectors are appropriately set

refactor: removed some commented lines

tests: added test for `plotIndiv.mint.plsda()` with `ellipse = TRUE`
@Max-Bladen Max-Bladen removed the wip work-in-progress label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Max-Bladen Max-Bladen

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for Issue #270 mixOmicsTeam/mixOmics
2 participants
@aljabadi @Max-Bladen