Clearer error/warnings messages in tune.spca()
#275
Assignees
Labels
enhancement-request
New feature or request
Comments
Max-Bladen
added a commit
that referenced
this issue
Dec 5, 2022
refactor: adjusted order of processes to increase efficiency in `repeat_cv_j()` within `tune.spca()`
Max-Bladen
added a commit
that referenced
this issue
Dec 5, 2022
enhance: added safety catch for NAs provided to `tune.spca()`. It replaces NAs with 0 and notifies user of the change
Max-Bladen
added a commit
that referenced
this issue
Dec 5, 2022
test: added new test file for `tune.spca()`
Max-Bladen
added a commit
that referenced
this issue
Dec 6, 2022
test: move `set.seed()` to see if it resolves issue
Max-Bladen
added a commit
that referenced
this issue
Dec 6, 2022
refactor: adjusted order of processes to increase efficiency in `repeat_cv_j()` within `tune.spca()` enhance: added safety catch for NAs provided to `tune.spca()`. It replaces NAs with 0 and notifies user of the change test: added new test file for `tune.spca()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Users are repeatedly encountering the following error:
Error: Unexpected error while trying to choose the optimum number of components. Please check the inputs and if problem persists submit an issue to https://github.com/mixOmicsTeam/mixOmics/issuesThis is really not helpful at all as it is so ambiguous. One user in particular encountered this when applying
tune.spca()on a dataset with a fewNAs.Describe the solution you'd like
A clearer warning/error message detailing exactly what's caused the function to stop.
Describe alternatives you've considered
Two primary alternatives:
Will likely go for the second option as it allows NAs to be handled, but users will be made aware of the risks associated with this.
The text was updated successfully, but these errors were encountered: