Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R-CMD-CHECK warnings & notes #280

Closed
Max-Bladen opened this issue Dec 12, 2022 · 0 comments Β· Fixed by #281
Closed

R-CMD-CHECK warnings & notes #280

Max-Bladen opened this issue Dec 12, 2022 · 0 comments Β· Fixed by #281
Assignees

Comments

@Max-Bladen
Copy link
Collaborator

🐞 Describe the bug:
When running the R-CMD-CHECK (locally or on remote), the following warnings / notes are raised:

βœ”  creating vignettes (3m 3.7s)
   Warning in person1(given = given[[i]], family = family[[i]], middle = middle[[i]],  :
     It is recommended to use 'given' instead of 'middle'.
─  checking for empty or unneeded directories
   Removed empty directory 'mixOmics/.vscode'
   Removed empty directory 'mixOmics/R/New folder'
   Removed empty directory 'mixOmics/build'
   Removed empty directory 'mixOmics/tests/testthat/_snaps'
N  checking installed package size ... 
     installed size is  9.5Mb
     sub-directories of 1Mb or more:
       R      1.4Mb
       data   3.3Mb
       doc    3.3Mb
N  checking R code for possible problems (32.6s)
   predict.block.pls: no visible global function definition for 'setNames'
   predict.block.spls: no visible global function definition for
     'setNames'
   predict.mint.splsda: no visible global function definition for
     'setNames'
   predict.mixo_pls: no visible global function definition for 'setNames'
   predict.mixo_spls: no visible global function definition for 'setNames'
   Undefined global functions or variables:
     setNames
   Consider adding
     importFrom("stats", "setNames")
   to your NAMESPACE file.

πŸ€” Expected behavior:
Ideally, there should be none (or very few) warnings/notes within this check

@Max-Bladen Max-Bladen added bug Something isn't working wip work-in-progress labels Dec 12, 2022
Max-Bladen added a commit that referenced this issue Dec 12, 2022
build: removed `middle` parameter from Al Abadi's reference in DESCRIPTION
@Max-Bladen Max-Bladen added build-issue and removed bug Something isn't working labels Dec 12, 2022
@Max-Bladen Max-Bladen linked a pull request Dec 12, 2022 that will close this issue
Max-Bladen added a commit that referenced this issue Dec 13, 2022
build: added explicit global definition for `setNames()`. Resolves NOTE in R-CMD-Check

build: removed `middle` parameter from Al Abadi's reference in DESCRIPTION
@Max-Bladen Max-Bladen removed the wip work-in-progress label Dec 13, 2022
@Max-Bladen Max-Bladen assigned Max-Bladen and unassigned aljabadi Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants