Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent error rates when using perf.mint.splsda and tune.mint.splsda #43

Closed
aljabadi opened this issue Oct 22, 2019 · 0 comments · Fixed by #191
Closed

inconsistent error rates when using perf.mint.splsda and tune.mint.splsda #43

aljabadi opened this issue Oct 22, 2019 · 0 comments · Fixed by #191
Assignees
Labels
bug Something isn't working

Comments

@aljabadi
Copy link
Collaborator

The performance of the tune.mint.splsda model at optimum hyperparameters:

data(stemcells)
X = stemcells$gene
Y = stemcells$celltype
study <- stemcells$study
tune.mint = tune.mint.splsda(X = X, Y = Y, study = study, ncomp = 2, test.keepX = seq(1, 100, 5),
                 dist = "max.dist", progressBar = FALSE)
plot(tune.mint)

image

Should be similar to that of perf.mint.splsda using the same hyperparameters:

mint.splsda.res = mint.splsda(X = X, Y = Y, study = study, ncomp = 2,
                              keepX = tune.mint$choice.keepX)

mint.splsda.res # lists useful functions that can be used with a MINT object

perf.mint = perf.mint.splsda(mint.splsda.res, progressBar = FALSE, dist = 'max.dist')

plot(perf.mint)

image

A possible solution is to ensure LOGOCV and perf.mint.splsda (and possibly other perf functions) call the same internal that does dev/test on studies and then make sure the outputs are identical as well.

@aljabadi aljabadi added the bug Something isn't working label Oct 22, 2019
@aljabadi aljabadi self-assigned this Oct 22, 2019
@Max-Bladen Max-Bladen self-assigned this Mar 14, 2022
@Max-Bladen Max-Bladen added the wip work-in-progress label Mar 15, 2022
Max-Bladen added a commit that referenced this issue Mar 15, 2022
@Max-Bladen Max-Bladen linked a pull request Mar 15, 2022 that will close this issue
@Max-Bladen Max-Bladen added wip work-in-progress and removed wip work-in-progress labels Mar 16, 2022
@Max-Bladen Max-Bladen removed the wip work-in-progress label Mar 20, 2022
@Max-Bladen Max-Bladen added the ready-to-review for all PRs that are ready to be reviewed. including complex, larger commits label Sep 7, 2022
Max-Bladen added a commit that referenced this issue Dec 8, 2022
Homogenised way in which `tune.mint.splsda()` and `perf.mint.splsda()` calculate BER, such that now both use weighted average of BER across studies. Added unit tests to ensure this homogenity
@Max-Bladen Max-Bladen removed the ready-to-review for all PRs that are ready to be reviewed. including complex, larger commits label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants