Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR addressing Issue #171 #176

Merged
merged 1 commit into from
Dec 8, 2022
Merged

PR addressing Issue #171 #176

merged 1 commit into from
Dec 8, 2022

Conversation

Max-Bladen
Copy link
Collaborator

@Max-Bladen Max-Bladen commented Mar 7, 2022

Despite cim() handling pca and spca object via the same code, their output components are different. This PR adds the $x and $rotation components to the pca object.

This isn't the cleanest fix as it means there is essentially double ups in the pca object. pca.object$x are the variates while pca.object$variates is the contains the same values but is structured a list of length 1. Downstream functions (such as network() and cim() access these components differently. Will clean this up in the future

@Max-Bladen Max-Bladen self-assigned this Mar 7, 2022
@Max-Bladen Max-Bladen changed the title Added $x and $rotation to pca() output Fix for Issue #171 Mar 8, 2022
@Max-Bladen Max-Bladen requested a review from aljabadi March 8, 2022 22:56
@Max-Bladen Max-Bladen linked an issue Mar 9, 2022 that may be closed by this pull request
@Max-Bladen Max-Bladen added the bug-fix For PR's that address an Issue with `bug` label label Mar 9, 2022
@Max-Bladen Max-Bladen added the ready-to-review for all PRs that are ready to be reviewed. including complex, larger commits label Sep 22, 2022
@Max-Bladen Max-Bladen changed the title Fix for Issue #171 Bug Fix, Issue #171 Nov 28, 2022
@Max-Bladen Max-Bladen changed the title Bug Fix, Issue #171 PR addressing Issue #171 Nov 28, 2022
@Max-Bladen Max-Bladen merged commit 6530fdc into master Dec 8, 2022
@Max-Bladen Max-Bladen deleted the issue-171 branch December 8, 2022 22:20
@Max-Bladen Max-Bladen removed the ready-to-review for all PRs that are ready to be reviewed. including complex, larger commits label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix For PR's that address an Issue with `bug` label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cim() function cannot take pca objects
1 participant