PR addressing Issue #172 #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used for testing general functionality of the `perf()` function. The check added here tests for the case when `nrepeat < 3` and `validation != 'loo'`
Max-Bladen
added
the
ready-to-review
Max-Bladen
removed
the
ready-to-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted code within the
forloop atline 1007such that for each dist metric and error metric, it checks if there is more than 2 repeats. If so, does the same as before. If not, it takes the minimum error rate (or ifnrepeat=2, then the minimum mean error rate across the two repeats)Also added printed note warning user than with less than
nrepeat = 3, results are much to subject to random chance (and that a t test is not employed, rather just a minimum) -line 798