PR addressing Issue #233 #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Max-Bladen
added
ready-to-review
Max-Bladen
added
enhancement-implementation
Max-Bladen
changed the title
Max-Bladen
changed the title
feat: added `size.node` parameter to `network()`. allows users to adjust the size of the vertices. also slightly adjusts how `cex.node.name` is used, provides greater user input to label size.
refactor: bounds `size.node` between 0 - 1.
refactor: changed default value of `size.node`
feat: added `graph.scale` parameter to `network()`. Allows for the general scaling up or down of the entire plot. More specifically, changes the upper bounds of the plotting space to increase/decrease distance and size of vertices
feat: when `shape.node == "none"` in `network()`, a color is now applied
refactor: adjusted the default colours used when applying `network()` in NON-multiblock contexts
tests: added tests for the new parameters and functionality of `network()`
fix: removed part of checks which was causing consistent warnings/errors
fix: added extra check for `shape.node` to avoid error and adjusted scaling of node size
docs: updated documentation for `network()` with new parameters
Max-Bladen
force-pushed
the
issue-233
branch
from
8253818
to
22dbbbf
Compare
|
Second set of commits on 13/12/2022 reflect initial set of commits, but replicated after the branch was rebased to master following PR #281. |
Max-Bladen
removed
the
ready-to-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains numerous changes to the
network()function. Users noted that a lack of control over vertex size and distances made for difficulty in plotting. Vertices frequently overlapped, covering the edges completely - essentially nullifying the purpose of the figure. The following changes were made:graph.scaleparameter: influences the scale of the entire network. Increasing this value essentially "zooms out" from the plot, decreasing vertex size and proximity.network()functions the same as prior to PR)size.nodeparameter: influences the size of the vertices. Works independently fromgraph.scale.network()functions the same as prior to PR)shape.node == "none", then the vertex labels will be coloured in the same fashion as the vertices would be.network()on different objects