Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #237 #238

Merged
merged 3 commits into from
Sep 15, 2022
Merged

Fix for Issue #237 #238

merged 3 commits into from
Sep 15, 2022

Conversation

Max-Bladen
Copy link
Collaborator

Addresses issue raised in this forum post.

Adjusted get.name.and.value() to ensure names of selected values are retained. Also added check in plotVar() to remove the single Y feature from cord.X as this is unnecessary to plot. This is due to the single Y feature always having correlation of -1 or 1 with all components

@Max-Bladen Max-Bladen added bug-fix For PR's that address an Issue with `bug` label rapid-review for PRs which will take minimal time to review and close ready-to-review for all PRs that are ready to be reviewed. including complex, larger commits labels Sep 8, 2022
@Max-Bladen Max-Bladen linked an issue Sep 8, 2022 that may be closed by this pull request
fix: `plotVar()` can now utilise `block.pls` and `block.spls` objects which have a single Y feature (ie. (s)PLS1)
test: added tests to maintain coverage
fix: rectified error in new test causing failure.
@Max-Bladen Max-Bladen merged commit 41d0ac4 into master Sep 15, 2022
@Max-Bladen Max-Bladen removed rapid-review for PRs which will take minimal time to review and close ready-to-review for all PRs that are ready to be reviewed. including complex, larger commits labels Sep 22, 2022
@Max-Bladen Max-Bladen deleted the issue-237 branch September 22, 2022 22:17
@knokknok
Copy link

The

      if (any(sapply(cord.X, nrow) == 1)) {
          cord.X <- cord.X[-which(sapply(cord.X, nrow) == 1)]
        }

code now makes the following fail:

data(breast.TCGA)
X <- breast.TCGA$data.train$mirna
Y <- matrix(breast.TCGA$data.train$protein[,1], ncol=1)
rownames(Y) <- rownames(X)
pls.result <- pls(X, Y)
plotVar(pls.result, cex=c(3,4))

Erreur : cex must be either a vector of length 2 or a list of 2 vector components of length 184 and 1 respectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix For PR's that address an Issue with `bug` label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plotVar() not functioning on multiblock (s)PLS1
3 participants