This repository was archived by the owner on Jul 31, 2020. It is now read-only.
fix(websocket): Fix websocket auth in browsers #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we errored out when running in a browser with a 400 code - because no auth info was supplied. Fix is to take the auth info we would add to headers, and add to query string instead when working with the built-in `WebSocket` implementation. Tested in NodeJS and Browser (Firefox)
ProbablePrime
approved these changes
Mar 6, 2018
connor4312
approved these changes
Mar 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we errored out when running in a browser with a 400 code -
because no auth info was supplied. Fix is to take the auth info we would
add to headers, and add to query string instead when working with the
built-in
WebSocketimplementation.Tested in NodeJS and Browser (Firefox, Chrome)