Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-release-pr #1

Merged
merged 18 commits into from
Aug 24, 2020
Merged

auto-release-pr #1

merged 18 commits into from
Aug 24, 2020

Conversation

andooown
Copy link
Contributor

@andooown andooown commented Aug 24, 2020

自動リリースPRのActionを共通で使えるように移植しました。

内部で利用していたものからの差分は

  • 各リポジトリのブランチ運用に対応できるように baseBranch/headBranch/releasePRNumber のパラメーターを追加
  • PR本文とコメントのテンプレートをパラメーターで渡せるように改善

です。

GitHub Actionsのcomposite run steps actionではまだ uses をつかった既存のActionの利用ができないため、暫定的にDockerベースのActionとして構築しました。
毎回 docker build が走りますが、それを含めて1分以内で完了しているので一旦許容したいです。

ActionsのIssue(https://github.com/actions/runner/issues/646)では uses の利用もロードマップに入っているようなので、実装されたら移行する予定です。

@github-actions
Copy link

PR body is updated!

diff

--- 

+++ 

@@ -1 +1,11 @@

-TBD
+## Changes
+
+- Create auto-release-pr action
+- Test auto-release-pr
+- Convert to Docker based action
+- Remove unused key
+- Set name
+- Run ls
+- Specify absolute path
+- Pass args for the number of PR
+- [temp] dummy body

@andooown
Copy link
Contributor Author

👍

@github-actions
Copy link

PR body is updated!

diff

--- 

+++ 

@@ -9,3 +9,11 @@

 - Specify absolute path
 - Pass args for the number of PR
 - [temp] dummy body
+- Revert "[temp] dummy body"
+
+This reverts commit 75620bfce6722c9ca489c0ed8ab63ee6181526e4.
+- Fix to use passed value
+- README
+- Link to auto-release-pr
+- Make template configurable
+- [temp] dummy body

@github-actions
Copy link

diff

+++

@@ -1,4 +1,4 @@

-## Changes
+差分

  • Create auto-release-pr action

  • Test auto-release-pr
    @@ -10,10 +10,10 @@

  • Pass args for the number of PR

  • [temp] dummy body

  • Revert "[temp] dummy body"

-This reverts commit 75620bf.

  • Fix to use passed value
  • README
  • Link to auto-release-pr
  • Make template configurable
    -- [temp] dummy body
    +- [temp] test

+以上

This reverts commit 0d2054c.
@andooown
Copy link
Contributor Author

andooown commented Aug 24, 2020

image

テンプレートの差し込みも動いた 👍

@andooown andooown marked this pull request as ready for review August 24, 2020 09:10
Copy link
Contributor

@enerick enerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andooown andooown merged commit 964ec33 into master Aug 24, 2020
@andooown andooown deleted the work/auto-release-pr branch August 24, 2020 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants