Add CI for support-ar6.0.z #18

akariiijima · 2023-06-23T03:34:28Z

Goodbye TravisCI, Welcome GithubActions

TravisCI is currently not working. This is probably because it was not maintained. Therefore, we will adopt GithubActions instead of using TravisCI.

CI for support-ar6.0.z

Matrix build test for ruby 2.4-2.7 ✖️ rails 5.0.0-6.0.6

Fix gemfiles for some reasons about dependencies

Add gem rails for require "rails" in spec/spec_helper.rb
Use gem mysql2 0.4.x less than rails 5.1.6, and use gem mysql2 0.5.x more than rails 5.1.6
- https://github.com/rails/rails/blob/5-1-stable/activerecord/CHANGELOG.md#rails-516-march-29-2018
In ruby 2.4 or less, there are several gem dependencies
- nokogiri
  - bundle install will install a native gem without any additional action in more then ruby 2.5, but in ruby 2.4 or less, need to add gem nokogiri.
    - https://github.com/sparklemotion/nokogiri
  - With the addition of the above adding gem nokogiri 1.10, loofah should be pin version 2.20.2
    - Getting errors using Nokogiri < 1.12 flavorjones/loofah#266
    - Pin loofah for <= ruby 2.4 since they removed support in a patch release getsentry/sentry-ruby#2041
- dalli
  - Add gem dalli for require "dalli" in spec/active_record/turntable/sequencer/katsubushi_spec.rb
  - dalli should be pin version 2
  - Dalli 3.0 petergoldstein/dalli#758

Some jobs failed because...

More than rails 6 support only ruby more than 2.5, so ruby 2.4 or less is failed CI

hirocaster · 2023-06-23T05:05:00Z

gemfiles/rails5_0_0.gemfile

@@ -1,10 +1,14 @@
 source "https://rubygems.org"

+gem "rails", "5.0.0"


Why did you need to add a gem such as Rails?

#18 (comment)

hirocaster · 2023-06-23T05:05:57Z

gemfiles/rails5_1_4.gemfile

 gem "mysql2", "~> 0.4.4"

-gem "minitest", "< 5.3.4"
-gem "mocha", "~> 0.14", require: false
+gem "nokogiri", "~> 1.10" if RUBY_VERSION.to_f < 2.5


Why are these making changes?

#18 (comment)

hirocaster · 2023-06-23T06:29:32Z

Glad you sent us a PR, and we will be sure to keep you posted on our progress. 😄
However, it would be very helpful if you could explain the reasons for the increase in dependence as it seems to be increasing.

akariiijima · 2023-06-26T01:43:52Z

@hirocaster
I added descriptions about fix reasons!
Please check and let me know if you have some questions.

hirocaster · 2023-06-26T07:44:03Z

#18 (comment)

Why did you need to add a gem such as Rails?

I looked at the DESCRIPTION but could not find a reason for this.

akariiijima · 2023-06-27T08:18:32Z

About adding "gem rails", I referenced original file (ex: gemfiles/rails6_0_4.gemfile, etc...)😄

hirocaster · 2023-06-27T08:35:16Z

Okay, I understand.
I recognized that I may need to organize gemfile as it should not inherently depend on Rails.

akariiijima · 2023-06-28T06:22:53Z

gem rails is needed for require rails

activerecord-turntable/spec/spec_helper.rb

Line 6 in 3d4a955

require "rails"

Gemfiles seem to be need not to change in this last commit. 👍

hirocaster · 2023-08-24T12:36:32Z

spec/active_record/turntable/active_record_ext/query_cache_spec.rb

-    ensure
-      if ActiveRecord::Turntable::Util.ar60_or_later?
-        ActiveRecord::Base.connection_handlers = original_handlers
+      begin


This commit is duplicate #19.
Please, fix the change commits.

…rails by default

…ore than rails 5.1.6)

…iles

railties and actionview gems have been added to gemfiles not having them. This is because they are dependencies of rails.

bundle install will install a native gem without any additional action : https://github.com/sparklemotion/nokogiri loofah should be pin version 2.20.2 : flavorjones/loofah#266, getsentry/sentry-ruby#2041

Pin gem dalli version 2 if ruby < 2.5 : petergoldstein/dalli#758

…ns instead

akariiijima self-assigned this Jun 23, 2023

hirocaster reviewed Jun 23, 2023

View reviewed changes

akariiijima force-pushed the add-ci-for-support-ar6.0.Z branch from b508d40 to b8033c5 Compare June 27, 2023 09:28

akariiijima changed the title ~~Add CI for support-ar6.0.z~~ [WIP] Add CI for support-ar6.0.z Jun 27, 2023

akariiijima changed the title ~~[WIP] Add CI for support-ar6.0.z~~ Add CI for support-ar6.0.z Jun 28, 2023

akariiijima force-pushed the add-ci-for-support-ar6.0.Z branch from 26d1b18 to 7477a08 Compare July 7, 2023 01:00

akariiijima changed the title ~~Add CI for support-ar6.0.z~~ [WIP] Add CI for support-ar6.0.z Jul 28, 2023

akariiijima force-pushed the add-ci-for-support-ar6.0.Z branch 2 times, most recently from e64afe9 to 7bcbe4f Compare August 23, 2023 09:28

akariiijima changed the title ~~[WIP] Add CI for support-ar6.0.z~~ Add CI for support-ar6.0.z Aug 23, 2023

hirocaster requested changes Aug 24, 2023

View reviewed changes

akariiijima added 11 commits August 28, 2023 16:27

Add rails 6.0.1, 6.0.2, 6.0.3, 6.0.5, 6.0.6 gemfiles

1814a67

Delete gem minitest because minitest is a testing library built into …

a7e1bba

…rails by default

Delete gem mocha because of not being used now

97226a4

Add gem mysql ~> 0.4.4 to rails 5.0.7

79b2a12

Add gem mysql ~> 0.5.2 to rails 5.1.6 (mysql 0.5.X is supported for m…

1ebf5ab

…ore than rails 5.1.6)

Add rails 5.1.7, 5.2.2, 5.2.3, 5.2.4, 5.2.5, 5.2.6, 5.2.7, 5.2.8 gemf…

f4052d4

…iles

Add gem rails because rails is needed in spec

04d0cf9

railties and actionview gems have been added to gemfiles not having them. This is because they are dependencies of rails.

Pin gem nokogiri/loofah version if ruby < 2.5

a3c2cdd

bundle install will install a native gem without any additional action : https://github.com/sparklemotion/nokogiri loofah should be pin version 2.20.2 : flavorjones/loofah#266, getsentry/sentry-ruby#2041

Add gem dalli because dalli is needed in spec

3e9c3b1

Pin gem dalli version 2 if ruby < 2.5 : petergoldstein/dalli#758

Add workflows for ruby 2.4 - 2.7 in GithubActions

692ed74

Goodbye travisCI because of not being maintained, and use GithubActio…

1af32dc

…ns instead

akariiijima force-pushed the add-ci-for-support-ar6.0.Z branch from 7999f54 to 1af32dc Compare August 28, 2023 07:28

hirocaster merged commit 9673991 into mixigroup:support-ar6.0.Z Aug 30, 2023

hirocaster mentioned this pull request Aug 31, 2023

Change CI matrix, Not support Ruby 2.4 in Rails6. #20

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CI for support-ar6.0.z #18

Add CI for support-ar6.0.z #18

akariiijima commented Jun 23, 2023 •

edited

Loading

hirocaster Jun 23, 2023

akariiijima Jul 20, 2023

hirocaster Jun 23, 2023

hirocaster Jul 6, 2023

hirocaster commented Jun 23, 2023

akariiijima commented Jun 26, 2023 •

edited

Loading

hirocaster commented Jun 26, 2023

akariiijima commented Jun 27, 2023

hirocaster commented Jun 27, 2023 •

edited

Loading

akariiijima commented Jun 28, 2023

hirocaster Aug 24, 2023

akariiijima Aug 28, 2023

		@@ -1,10 +1,14 @@
		source "https://rubygems.org"

		gem "rails", "5.0.0"

Add CI for support-ar6.0.z #18

Add CI for support-ar6.0.z #18

Conversation

akariiijima commented Jun 23, 2023 • edited Loading

Goodbye TravisCI, Welcome GithubActions

CI for support-ar6.0.z

Fix gemfiles for some reasons about dependencies

Some jobs failed because...

hirocaster Jun 23, 2023

Choose a reason for hiding this comment

akariiijima Jul 20, 2023

Choose a reason for hiding this comment

hirocaster Jun 23, 2023

Choose a reason for hiding this comment

hirocaster Jul 6, 2023

Choose a reason for hiding this comment

hirocaster commented Jun 23, 2023

akariiijima commented Jun 26, 2023 • edited Loading

hirocaster commented Jun 26, 2023

akariiijima commented Jun 27, 2023

hirocaster commented Jun 27, 2023 • edited Loading

akariiijima commented Jun 28, 2023

hirocaster Aug 24, 2023

Choose a reason for hiding this comment

akariiijima Aug 28, 2023

Choose a reason for hiding this comment

akariiijima commented Jun 23, 2023 •

edited

Loading

akariiijima commented Jun 26, 2023 •

edited

Loading

hirocaster commented Jun 27, 2023 •

edited

Loading