Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elements in tables will brake markdown syntax #3

Open
alexanderadam opened this issue Jan 12, 2018 · 5 comments
Open

Elements in tables will brake markdown syntax #3

alexanderadam opened this issue Jan 12, 2018 · 5 comments

Comments

@alexanderadam
Copy link

Thank you very much for turndown.
It is very well done.
I just found a small issue:

 <table>
  <tr>
    <th>Please no line break here:<div></div></th>
  </tr>
  <tr>
    <td>Oh no!<td>
  </tr>
</table>

should result in

| Please no line break here: |
| --- |
| Oh no! |

But I get

| Please no line break here:
 |
| --- |
| Oh no! |  |

instead.

Have a nice day! ☀️

@hansy
Copy link

hansy commented Dec 5, 2018

Similarly:

<table>
  <thead>
    <tr>
      <td>Heading 1</td>
      <td>Heading 2</td>
    </tr>
  </thead>
  <tbody>
    <tr>
      <td>Foo</td>
      <td>
        <p>Bar</p>
      </td>
    </tr>
  </tbody>
</table>

becomes

| Heading 1 | Heading 2 |
| --- | --- |
| Foo |
Bar

 |

when it should be

| Heading 1 | Heading 2 |
| --- | --- |
| Foo | <p>Bar</p> |

@bbgaurav
Copy link

Hello,

When is this issue expected to be fixed ?

Thanks,
GBB

@domchristie
Copy link
Collaborator

I'm afraid there is no scheduled fix at the moment. I recommend that you create a custom rule to handle your use-case

@postatum
Copy link

postatum commented Oct 1, 2019

I have a similar problem with tables.

@philiprenich
Copy link

Is this repo still under development? Would love to see this fixed as adding elements like p instead of a table is very common.

Ndpnt pushed a commit to OpenTermsArchive/engine that referenced this issue Jul 29, 2020
Official plugin is not maintained, the joplin-turndown-plugin-gfm fork contains fixes for HTML tables conversions
See mixmark-io/turndown-plugin-gfm#3
sh78 added a commit to sh78/markdownizr-chrome that referenced this issue Apr 3, 2021
- Configure Turndown for GFM per [docs][1]
- Use [a fork of turndown-plugin-gfm][2] due to [issues with the
  original turndown-plugin-gfm][3]
- Remove custom strikethrough logic which is now redundant due to GFM
  plugin

[1]: https://github.com/domchristie/turndown#usepluginarray
[2]: https://www.npmjs.com/package/joplin-turndown-plugin-gfm
[3]: mixmark-io/turndown-plugin-gfm#3
martinratinaud pushed a commit to OpenTermsArchive/engine that referenced this issue Aug 6, 2021
Official plugin is not maintained, the joplin-turndown-plugin-gfm fork contains fixes for HTML tables conversions
See mixmark-io/turndown-plugin-gfm#3
martinratinaud pushed a commit to OpenTermsArchive/engine that referenced this issue Aug 6, 2021
Official plugin is not maintained, the joplin-turndown-plugin-gfm fork contains fixes for HTML tables conversions
See mixmark-io/turndown-plugin-gfm#3
maxpatiiuk added a commit to maxpatiiuk/text-hoarder that referenced this issue Feb 8, 2024
Workaround for mixmark-io/turndown-plugin-gfm#3
and other issues too ... by migrating to a more well-maintained fork of
Turndown.

Though the fork also has it's own issues. Applying workarounds for:
Workaround for laurent22/joplin#9885
Workaround for laurent22/joplin#9884
Workaround for laurent22/joplin#9881
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants