Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix space-padding in code span rule #317

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

martincizek
Copy link
Collaborator

Code span rule now exactly conforms to the spec.

Quality assurance:

  • Fixed expectation in a test expecting a wrong output.
  • The fixed test matches fixed output.
  • Code should now be more robust in terms of future development.

Performance:

  • Saved one trim()
  • Executing one more regexp (roughly).
  • Less code. :)

From the commit message:

@martincizek martincizek force-pushed the code-span-rule-fix branch 2 times, most recently from de19c1f to bb67543 Compare July 6, 2020 18:36
@martincizek
Copy link
Collaborator Author

@pavelhoral Asking for a code review, thanks.

Copy link
Collaborator

@pavelhoral pavelhoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect space-padding in code span rule
2 participants