Ensure isBlank checks for significant elements within the given node #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRY up the is/has functions and always use uppercase to prevent excessive toLowerCase calls
This was referenced May 12, 2020
|
First of all, thanks so much for this library! I've found it suppppper useful. By chance, do you know when this fix might get published? I could really use this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isBlankcurrently checks:'A', 'TH', 'TD', 'IFRAME', 'SCRIPT', 'AUDIO', 'VIDEO',textContentis blank,This works for most cases, although fails when the element contains a meaningful element and has a blank
textContente.g.(Adapted from: #293)
This pull request checks if the element contains a meaningful element. It also adds
'TABLE', 'THEAD', 'TBODY', 'TFOOT'to the list of meaningful elements.Fixes #293
Fixes #276
Closes #277
Closes #311