feat: initial release #1

skeggse · 2020-09-08T19:04:19Z

see https://github.com/mixmaxhq/boddle/blob/initial-release/README.md

honestly the more I type it the more I dislike the name

This commit is relatively simple: - move chunks of code from backbone.js to new files - apply eslint + prettier changes (100% automated) The goal of this commit is to make especially obvious and plain what we're actually changing in subsequent commits.

BREAKING CHANGE: loss of support for `History`, `Router` and `View`.

This helps make future commits more comprehensible in their refactor.

skeggse · 2020-09-08T19:43:57Z

src/Collection.js

+      if (!model.validationError) return model;
+      this.trigger('invalid', this, model.validationError, {
+        ...options,
+        validationError: model.validationError,


This functionality was previously provided by an undocumented side-effect of the Model constructor.

skeggse · 2020-09-08T19:44:50Z

src/Collection.js

-_.extend(Collection.prototype, Events, {
-  // The default model for a collection is just a **Backbone.Model**.
-  // This should be overridden in most cases.
-  model: Model,


Prototype-inherited fields like these end up tacked on after the class definition.

skeggse · 2020-09-08T19:46:10Z

src/Collection.js

+  mixinMethods(
+    Collection,
+    [
+      ['chain', _.chain, 1],


Methods by reference instead of name so we can appropriately import them from lodash at compile time and trim the build accordingly. Still unfortunate that a lot of Backbone's value is by mixing in these functions.

skeggse · 2020-09-08T19:46:47Z

src/Model.js

+export const Model = /*#__PURE__*/ (() => {
+  // eslint-disable-next-line no-shadow
+  const Model = class Model {
+    static extend = extend;


Compat. Might be able to remove this in a future version.

skeggse · 2020-09-08T19:47:23Z

src/Model.js

+    // If you specify an attribute name, determine if that attribute has changed.
+    hasChanged(attr) {
+      if (attr == null) return !_.isEmpty(this.changed);
+      return _.has(this.changed, [attr]);


For exact parity with backbone (via underscore), put the attribute in an array so it isn't interpreted as a dot-delimited path.

skeggse · 2020-09-08T19:55:31Z

src/events.js

-// receive the true name of the event as the first argument).
-Events.trigger = function (name) {
-  if (!this._events) return this;
+    const ids = obj ? [obj._listenId] : keysIn(listeningTo);


Note that with regenerator, we end up with this getting deoptimized back to the equivalent of Object.keys.

skeggse · 2020-09-08T19:56:21Z

src/extend.js

-    child = function () {
-      return parent.apply(this, arguments);
-    };
+    child = class extends parent {};


Note that the class syntax automatically configures the prototype, including the prototype.constructor field.

skeggse · 2020-09-08T19:57:00Z

src/fetch.js

+    parsed.append(key, value);
+  }
+  return url.slice(0, queryIndex + 1) + parsed.toString();
+}


This function (stringifyGETParams) is notably different from upstream.

skeggse · 2020-09-08T19:57:22Z

src/flags.js

+export function setEmulateHTTP(value) {
+  emulateHTTP = value;
+}
+
+export function setEmulateJSON(value) {
+  emulateJSON = value;
+}


Gotta make these setters - mostly for the tests, but also for use downstream.

skeggse · 2020-09-08T19:59:02Z

src/utils.js

+  for (i = 0; i < tail.length; i++) tail[i] = array[i + at];
+  for (i = 0; i < length; i++) array[i + at] = insert[i];
+  for (i = 0; i < tail.length; i++) array[i + length + at] = tail[i];
+}


Probably able to use Array#splice instead, or at least optimize to remove the need for an additional tail array.

According to jashkenas#4027 (comment), splice is sloooow.

Ah I misread the comment - splice in a loop is slow, which is 100% accurate because then you're repeatedly copying the tail. Much better to bailout to a manual splice insertion implementation when there are too many items.

README.md

Co-authored-by: Shil Sinha <shil.sinha@gmail.com>

src/Collection.js

src/mixin-methods.js

Co-authored-by: Shil Sinha <shil.sinha@gmail.com>

skeggse requested a review from shils September 8, 2020 19:04

skeggse force-pushed the initial-release branch 4 times, most recently from d12c38c to cc16596 Compare September 8, 2020 19:19

Eli Skeggs added 3 commits September 8, 2020 12:35

refactor: separate out sources

d14e44e

This commit is relatively simple: - move chunks of code from backbone.js to new files - apply eslint + prettier changes (100% automated) The goal of this commit is to make especially obvious and plain what we're actually changing in subsequent commits.

refactor: remove unsupported functionality

ad5c674

BREAKING CHANGE: loss of support for `History`, `Router` and `View`.

refactor: remove umd wrapper

b194444

skeggse force-pushed the initial-release branch from 0351e85 to 879210c Compare September 8, 2020 19:39

Eli Skeggs added 4 commits September 8, 2020 12:52

refactor: reorder events functions

2ed8bb2

This helps make future commits more comprehensible in their refactor.

feat: initial release

001966d

refactor: prefer this over bound this

01e1095

docs: add more caveats

dbc8411

skeggse force-pushed the initial-release branch from 8de8849 to dbc8411 Compare September 8, 2020 19:53

skeggse commented Sep 8, 2020

View reviewed changes

shils reviewed Sep 8, 2020

View reviewed changes

README.md Outdated Show resolved Hide resolved

docs: clarify underscore removal

37034e8

Co-authored-by: Shil Sinha <shil.sinha@gmail.com>

shils reviewed Sep 8, 2020

View reviewed changes

src/Collection.js Show resolved Hide resolved

shils reviewed Sep 8, 2020

View reviewed changes

src/mixin-methods.js Outdated Show resolved Hide resolved

Eli Skeggs and others added 4 commits September 8, 2020 14:17

docs: remove underscore reference

0637c08

Co-authored-by: Shil Sinha <shil.sinha@gmail.com>

style: remove unnecessary whitespace

55591f3

perf: optimize splice

38babfb

test: add explicit splice tests

131385a

shils approved these changes Sep 9, 2020

View reviewed changes

chore: rename to neckbone

8ac58c2

skeggse merged commit 7e11de2 into master Sep 9, 2020

skeggse deleted the initial-release branch September 9, 2020 17:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: initial release #1

feat: initial release #1

skeggse commented Sep 8, 2020 •

edited

Loading

skeggse Sep 8, 2020

skeggse Sep 8, 2020

skeggse Sep 8, 2020

skeggse Sep 8, 2020

skeggse Sep 8, 2020

skeggse Sep 8, 2020

skeggse Sep 8, 2020

skeggse Sep 8, 2020

skeggse Sep 8, 2020

skeggse Sep 8, 2020 •

edited

Loading

skeggse Sep 8, 2020

skeggse Sep 9, 2020

feat: initial release #1

feat: initial release #1

Conversation

skeggse commented Sep 8, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skeggse Sep 8, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skeggse commented Sep 8, 2020 •

edited

Loading

skeggse Sep 8, 2020 •

edited

Loading