Fix First App Open not always being able to be triggered
#496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sources/MixpanelInstance.swift
Outdated
| @@ -214,7 +214,7 @@ open class MixpanelInstance: CustomDebugStringConvertible, FlushDelegate, AEDele | |||
| #endif // DECIDE | |||
|
|
|||
| #if !os(OSX) && !os(watchOS) | |||
| init(apiToken: String?, flushInterval: Double, name: String, optOutTrackingByDefault: Bool = false) { | |||
| init(apiToken: String?, flushInterval: Double, name: String, optOutTrackingByDefault: Bool = false, trackAutomaticEvents: Bool = false) { | |||
There was a problem hiding this comment.
default is false here? but true in Mixpanel.swift?
There was a problem hiding this comment.
should be true, good catch
jaredmixpanel
approved these changes
Jan 10, 2022
zihejia
force-pushed
the
fix-first-app-open
branch
from
75c83de
to
6e9ddd0
Compare
zihejia
force-pushed
the
fix-first-app-open
branch
from
6e9ddd0
to
4f25ef6
Compare
zihejia
changed the title
First App Open not always being able to be triggeredFirst App Open not always being able to be triggered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First App Opennot always being able to be triggeredtrackAutomaticEventsininitialize: Whether or not to collect common mobile events