track implementation and each launch #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredmixpanel
commented
May 3, 2022
Sources/Network.swift
Outdated
| "distinct_id": distinctId, | ||
| "$lib_version": properties["$lib_version"] ?? AutomaticProperties.libVersion()]) {(current, _) in current } | ||
| "$lib_version": AutomaticProperties.libVersion()]) {(current, _) in current } |
There was a problem hiding this comment.
The {(current, _) in current } closure keeps the values in properties for any keys that are already present.
There was a problem hiding this comment.
zihejia
reviewed
May 5, 2022
Sources/MixpanelInstance.swift
Outdated
| #if DEBUG | ||
| Network.sendHttpEvent(eventName: "Toggle SDK Logging", apiToken: "metrics-1", distinctId: apiToken, properties: ["Logging Enabled": false]) | ||
| Network.sendHttpEvent(eventName: "Toggle SDK Logging", apiToken: "metrics-1", distinctId: apiToken, properties: ["Logging Enabled": true]) |
zihejia
reviewed
May 5, 2022
Sources/Network.swift
Outdated
| headers: ["Accept-Encoding": "gzip"], | ||
| parse: responseParser) | ||
| Network.apiRequest(base: BasePath.DefaultMixpanelAPI, resource: engageResource) { _, _, _ in } success: { _, _ in } | ||
| if !(eventName == "Integration") { |
There was a problem hiding this comment.
better add a new param like updatePeople, it can be defaulted to true.
zihejia
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some additional developer experience internal tracking