Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all internal tracking and fix crashes caused by it #646

Merged
merged 2 commits into from
May 4, 2024
Merged

Remove all internal tracking and fix crashes caused by it #646

merged 2 commits into from
May 4, 2024

Conversation

zihejia
Copy link
Contributor

@zihejia zihejia commented May 3, 2024 •
edited
Loading

address #644 #645

@zihejia zihejia requested a review from jaredmixpanel May 3, 2024 23:40
jaredmixpanel
jaredmixpanel approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@jaredmixpanel jaredmixpanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zihejia zihejia added the bug label May 3, 2024
@zihejia zihejia changed the title Remove all internal tracking Remove all internal tracking and fix crashes May 3, 2024
@zihejia zihejia changed the title Remove all internal tracking and fix crashes Remove all internal tracking and fix crashes caused by it May 3, 2024
@zihejia zihejia merged commit a46229f into master May 4, 2024
2 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Nov 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredmixpanel jaredmixpanel jaredmixpanel approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zihejia @jaredmixpanel