Replace ngAnnotate with babel-plugin-angularjs-annotate #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 24, 2017 17:14
- added gulp-babel dependency - updated buildJS script to use babel plugin - added missing "ngInject" annotations: ng-annotate was doing a good job at inferring the missing annotation :) - upgraded major versions of browserify, envify, gulp-sourcemaps (not required)
- extracted gulp-babel instantiation to a function
jraoult
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Replaces the deprecated ng annotate (through
gulp-ng-annotate) with ababelplugin.ngAnnotatewas messing with soource maps and ES2015 arrow functions so that setting breakpoints inside them was impossible. This is inconvenient for debugging purposes.I also added some missing
ngInjectannotations that were discovered while switching to the new plugin.cf. olov/ng-annotate#245