Add es6 support #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
👍 thanks! Merged! |
|
published as |
|
Thanks! |
|
Ah, this is not recommend. Facebook stopped maintaining their Esprima fork. Meanwhile, the latest Esprima 2.x has a complete ES6 support already (see among others https://groups.google.com/d/msg/esprima/2jEogfxzjqI/B4GzlxDnFAAJ). I highly recommend updating to the latest Esprima 2.7.0 instead. |
|
Oh, my bad. Missed that. Tried last version of Esprima and indeed seems to support ES6. And if Facebook fork is no longer supported, I believe that as @ariya said, it'll be better to update to last Esprima version. Sorry for that guys! |
Merged
|
updated to Esprima 2, published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed from esprima to esprima-fb. Now it seems to parse well files with ES6 syntax