Add support for git submodules. Addresses issue #54. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixu
reviewed
Oct 11, 2016
| if (stat.isDirectory()) { | ||
| return true; | ||
| if (stat.isDirectory()) return true; | ||
| else { |
There was a problem hiding this comment.
nit: I strongly prefer if statements to always have curly braces, maybe make this a early return e.g. get rid of the else here
| else { | ||
| // check if the directory is a submodule | ||
| // addresses https://github.com/mixu/gr/issues/54 | ||
| var path = req.path.split(/(\\|\/)/).slice(0, -2).join('/'); |
There was a problem hiding this comment.
path.dirname(path.dirname(req.path))?
| stat = fs.statSync(path + '/.git/'); | ||
| if (stat.isDirectory()) { | ||
| stat = fs.statSync(path + '/.gitmodules') | ||
| if (stat.isFile()) return true; |
|
@mixu I updated the code according to your suggestions, and moved it into the catch block since statSync should throw an error when trying to access a non-existent directory. |
|
👍 thanks for making these changes and for the PR! Merged! |
|
published as |
|
@mixu you're welcome, thanks for the great tool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.