Use git rev-parse to check path correctness
#65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 23, 2017
bimlas
force-pushed
the
submodule-in-subdirectory
branch
from
5cb1191 to
b2163ba
Compare
Instead of check the existness of `.git` directory, use `git rev-parse` to check that `req.path` is in * a Git repository * a Git submodule * the root of the repo/submodule The old method didn't worked with submodules more than one level deep in the repo. Besides this if the $GIT_DIR differs from `.git` (cannot find a real life example), then the old method fails to work. Related to mixu#54
bimlas
force-pushed
the
submodule-in-subdirectory
branch
from
b2163ba to
ebbacfb
Compare
|
Finally, it works as expected. An example output (reformatted to be more readable): |
|
@mixu, please review and merge if you agree. |
|
thanks! sorry for the long delay in merging! |
|
published on npm as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of check the existness of
.gitdirectory, usegit rev-parseto check that
req.pathis inThe old method didn't worked with submodules more than one level deep in
the repo. Besides this if the $GIT_DIR differs from
.git(cannot finda real life example), then the old method fails to work.
Related to #54
It's using
git rev-parse --show-prefixwhich drops error if executed outside of Git repository; prints the prefix ("the current directory relative to Git root") if executed from a subdirectory. The behaviour if equal for Git repo and submodule too.Curently it's not working because I can't return true/false from exec, so I need help in making it usable.
Please be patient, it's my very first Node.js code and I'm beginner in Javascript too.