Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requirements.txt: Remove unneeded fabric/pycrypto/ecdsa dependencies #123

Merged
merged 2 commits into from
Sep 9, 2020
Merged

requirements.txt: Remove unneeded fabric/pycrypto/ecdsa dependencies #123

merged 2 commits into from
Sep 9, 2020

Conversation

Holzhaus
Copy link
Member

No description provided.

@rryan
Copy link
Member

rryan commented Aug 28, 2020

Fabric is still used for maintenance, e.g.
https://github.com/mixxxdj/manual#update-source-translations
and the fabfile.py is still there, so I think it makes sense to keep them in requirements.txt unless you switch to an alternative.

Are you trying to cut down on build time on netlify?

@Holzhaus
Copy link
Member Author

Yes. And also this is necessary for mixxxdj/mixxx#3047 because pycrypto takes long to build and causes issues on some systems.

@rryan
Copy link
Member

rryan commented Aug 28, 2020

Yes. And also this is necessary for mixxxdj/mixxx#3047 because pycrypto takes long to build and causes issues on some systems.

How about splitting them into a requirements-dev.txt ?

@Holzhaus
Copy link
Member Author

We could, but do we really need fabric? For example, fab tx_push is just wrapper for tx push -s. I think we can just remove it and update the README with the actual commands.

@Holzhaus
Copy link
Member Author

I updated the README. @rryan Please have a look.

@Holzhaus Holzhaus requested a review from rryan August 30, 2020 18:54
@Holzhaus
Copy link
Member Author

Holzhaus commented Sep 3, 2020

Merge?

@Holzhaus
Copy link
Member Author

Holzhaus commented Sep 5, 2020

Ping

@Holzhaus
Copy link
Member Author

Holzhaus commented Sep 9, 2020

@Be-ing Merge?

@Be-ing Be-ing merged commit ad6f3c3 into mixxxdj:manual-2.3.x Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rryan rryan Awaiting requested review from rryan

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Holzhaus @rryan @Be-ing