Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping for MIDI Controller Behringer DDM4000 #341

Conversation

git-developer
Copy link
Contributor

@git-developer git-developer commented Jan 8, 2021

Implementation PR: mixxxdj/mixxx#3542

@git-developer git-developer marked this pull request as ready for review May 3, 2021 18:46
@uklotzde
Copy link
Contributor

uklotzde commented May 7, 2021

@Holzhaus @Swiftb0y I don't have permission to merge the PR. Please do so. I also cannot approve the CI workflows.

@Holzhaus
Copy link
Member

Holzhaus commented May 7, 2021

Link check failure is unrelated.

@git-developer Thanks for the documentation so far, but I think it could be a bit more detailed. Could you add more documentation for each button (e.g. like the Pioneer DDJ-200 documentation does?

Since the mapping was already merged, I'll merge the documentation now, but I'd appreciate if you could make a follow-up PR.

CC @uklotzde

@Holzhaus Holzhaus merged commit 7ca9bbe into mixxxdj:2.3 May 7, 2021
@git-developer
Copy link
Contributor Author

Thanks for the approval and merge. I'll have a look into the referenced documentation as suggested and add another documentation PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants