Update denon_mc7000.rst #484

holopansel · 2022-05-13T13:12:53Z

I also created the two new svg files already linked in the document

.

holopansel · 2022-05-13T13:14:58Z

This update belongs to mixxxdj/mixxx#4729

uklotzde · 2022-05-13T22:00:15Z

source/hardware/controllers/denon_mc7000.rst

@@ -301,7 +304,8 @@ This mode lets you jump a number of beats while pushing a pad button once.
 Sampler Mode (pink LED)
 -----------------------

-8 samplers can be triggered from either Deck.
+8 samplers can be triggered from each Deck if MC7000.SamplerQty is set to 32. Deck 1 will play sampler 1 to 8, Deck 2 will play sampler 9 to 16, Deck 3 will play sampler 17 to 24 and Deck 4 will play sampler 25 to 32.


Most users will simply use the default mapping without any customization. The manual should primarily describe this and simply refer to the script if users intend to customize it.

As a regular user without any ambitions to program JavaScript I find the references to internals of the script more confusing than helpful.

TL;DR IMHO it would be sufficient to describe only the default behavior in the manual and document the options for customization in the script code.

I set the default to 16 samplers in the script now, so the user does not need to take any action before using, this works with the default skin.

comment for 32 samplers is now in the script code.

uklotzde · 2022-05-13T22:07:35Z

source/hardware/controllers/denon_mc7000.rst

+Apart from that the behavior is equal to Sampler Mode.
+
+8 samplers can be triggered from each Deck if MC7000.SamplerQty is set to 32. Deck 1 will play sampler 1 to 8, Deck 2 will play sampler 9 to 16, Deck 3 will play sampler 17 to 24 and Deck 4 will play sampler 25 to 32.
+If MC7000.SamplerQty is set to 16, Deck 1 and Deck 3 will play the samplers 1 to 8 and Deck 2 and Deck 4 will play the samplers 9 to 16.


I suggest to omit the description of the non-default behavior from the manual.

16 samplers will be the standard and therefore all 32 sampler information be removed from the manual.

uklotzde

I just left some thoughts about the intended audience of the manual. The existing MC 7000 page is overambitious in this respect and confuses regular users with extra information that is useless for them. Isolating the developer documentation in .. hint:: sections seems reasonable. Sometimes it is not clear what the default setting actually is if I select the controller in the preferences, knowing absolutely nothing about mapping scripts.

The SVG illustrations as a bonus are nice.

uklotzde · 2022-05-13T22:23:58Z

Please check the failing pre-commit action that complains about some formatting issues. The failing link checks are probably unrelated, ignore them.

holopansel · 2022-05-20T20:49:23Z

Thank you so far uklotzde,
I am going to continue here after swiftb0y approved the corresponding merge request. Otherwise there is a manual available for features that are not.

Swiftb0y · 2023-02-13T16:04:03Z

that serato flip logo might be trademarked. I think we should remove it just in case.

ronso0 · 2023-02-13T16:11:33Z

Just a hint:
the svg paths/objects should be filled (white I guess) so they are always readable, regardless of the browser used.
This is how it looks like with a dark theme:

holopansel · 2023-02-13T16:15:08Z

Thanks Ronso,
will change that.

JoergAtGithub · 2023-02-15T08:07:29Z

Pre-Commit is broken now. You can fix this by using pre-commit.patch artifact from the last CI build:
git apply pre-commit.patch
or you install pre-commit locally on your system: https://github.com/mixxxdj/mixxx/wiki/Using-Git#set-up-automatic-code-checking

holopansel · 2023-02-15T08:30:41Z

that serato flip logo might be trademarked. I think we should remove it just in case.

uploaded new files.

holopansel · 2023-02-15T13:54:31Z

before I uploaded the files, the background was set to ff (white), after applying the pre-commit patch file it is back to 00. So there is still the dark theme problem. Any ideas how to solve this?

ronso0 · 2023-02-15T21:15:03Z

could you please attach an example SVG (before) that got reverted by pre-commit?

holopansel · 2023-02-16T15:05:09Z

found a solution, will update again.

ronso0 · 2023-02-16T18:36:39Z

I don't see a white background in that image. At least not in the num pad rows

ronso0 · 2023-02-16T18:37:48Z

I think we should squash all commits when you're done. There's a lot of back and forth it seems.

holopansel · 2023-02-16T18:56:13Z

on my browser with dark theme it looks like this:

ronso0 · 2023-02-16T20:34:59Z

I don't know which svg editor you used, but if I download that file you posted last and put a gradient in the layer below it look s like this:

holopansel · 2023-02-17T06:07:11Z

The file used was already outdated by the time you used it, therefore I deleted the post. In the beginning I modified the files using inkscape, all later versions where I posted that I found a solution were modified using a text editor.
So please look at the complete manual https://github.com/holopansel/manual/blob/patch-1/source/hardware/controllers/denon_mc7000.rst with all updated files and let me know if this looks ok on your browser now. Thanks

ronso0 · 2023-02-17T13:36:14Z

I checked the netlify preview and set a dark background. Graphics look good now, thanks.
https://deploy-preview-484--mixxx-manual.netlify.app/hardware/controllers/denon_mc7000.html

I just noticed the controller overvew could be cropped, don't know if you like to squeeze that in as well
https://deploy-preview-484--mixxx-manual.netlify.app/_images/denon_mc7000.svg

ronso0 · 2023-02-17T13:40:12Z

@holopansel Do you work with git locally or with the Github web interface?
I'm asking because these are 22 commits by now and I always appreciate having a somewhat clean git history with meaningful commit messages. Locally, rebasing this branch is easy, I don't know if/how that works with the web interface.

JoergAtGithub

The added documentation of the new features itself is correct!

holopansel · 2023-02-17T19:46:45Z

The many commits result from using the web interface.

ronso0 · 2023-02-17T21:38:25Z

@JoergAtGithub If you agree I'd squash this into 2-3 commits and push to @holopansel's repo?

JoergAtGithub · 2023-02-18T01:02:55Z

Yes, I agree!

holopansel · 2023-02-19T21:43:38Z

would also be ok for me.

ronso0 · 2023-02-22T21:13:17Z

source/hardware/controllers/denon_mc7000.rst

+.. hint::
+   To use default Mixxx behaviour and allow playing multiple samplers at the same time you can set the user variable ``MC7000.prevSamplerStop`` inside the :ref:`JavaScript file<denon_mc7000_uservariables>` to ``false``.
+
+Pitch Mode (green LED)


Suggested change

Pitch Mode (green LED)

Pitch Play Mode (green LED)

I'll fix it.

ronso0 · 2023-02-22T21:22:11Z

@JoergAtGithub wanna take a final look before merge?

JoergAtGithub · 2023-02-22T21:49:36Z

LGTM!
The broken links are real, but unrelated to this PR.

JoergAtGithub · 2023-02-22T21:50:19Z

Thank you!

holopansel · 2023-02-23T19:19:05Z

Thank you all.

holopansel mentioned this pull request May 13, 2022

Mc7000 23 mixxxdj/mixxx#4729

Merged

uklotzde reviewed May 13, 2022

View reviewed changes

JoergAtGithub added the controllers label Feb 4, 2023

JoergAtGithub approved these changes Feb 17, 2023

View reviewed changes

JoergAtGithub added this to the 2.3.4 milestone Feb 20, 2023

JoergAtGithub mentioned this pull request Feb 22, 2023

2.3.4 Release mixxxdj/mixxx#11278

Merged

ronso0 force-pushed the patch-1 branch from 76147c3 to 872412a Compare February 22, 2023 21:02

ronso0 reviewed Feb 22, 2023

View reviewed changes

holopansel and others added 4 commits February 22, 2023 22:21

Denon MC7000: add padmodes Velocity Sampler & Pitch Play

f671677

flip logo removed, background opacity set to ff

e0eb8ed

svg cleanup, add white backgrounds

bce69a3

controller overview cropped

6f29d8a

ronso0 force-pushed the patch-1 branch from 872412a to 6f29d8a Compare February 22, 2023 21:21

JoergAtGithub merged commit 7a750c1 into mixxxdj:2.3 Feb 22, 2023

JoergAtGithub mentioned this pull request Feb 22, 2023

Kontrol S4 Mk3: add documentation for the device #550

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update denon_mc7000.rst #484

Update denon_mc7000.rst #484

holopansel commented May 13, 2022

holopansel commented May 13, 2022 •

edited by Swiftb0y

Loading

uklotzde May 13, 2022 •

edited

Loading

holopansel Feb 13, 2023

holopansel Feb 15, 2023

uklotzde May 13, 2022

holopansel Feb 13, 2023

uklotzde left a comment

uklotzde commented May 13, 2022

holopansel commented May 20, 2022 •

edited

Loading

Swiftb0y commented Feb 13, 2023

ronso0 commented Feb 13, 2023

holopansel commented Feb 13, 2023

JoergAtGithub commented Feb 15, 2023

holopansel commented Feb 15, 2023

holopansel commented Feb 15, 2023

ronso0 commented Feb 15, 2023

holopansel commented Feb 16, 2023

ronso0 commented Feb 16, 2023

ronso0 commented Feb 16, 2023

holopansel commented Feb 16, 2023

ronso0 commented Feb 16, 2023

holopansel commented Feb 17, 2023 •

edited

Loading

ronso0 commented Feb 17, 2023

ronso0 commented Feb 17, 2023

JoergAtGithub left a comment

holopansel commented Feb 17, 2023

ronso0 commented Feb 17, 2023

JoergAtGithub commented Feb 18, 2023

holopansel commented Feb 19, 2023

ronso0 Feb 22, 2023

ronso0 commented Feb 22, 2023

JoergAtGithub commented Feb 22, 2023

JoergAtGithub commented Feb 22, 2023

holopansel commented Feb 23, 2023

Update denon_mc7000.rst #484

Update denon_mc7000.rst #484

Conversation

holopansel commented May 13, 2022

holopansel commented May 13, 2022 • edited by Swiftb0y Loading

uklotzde May 13, 2022 • edited Loading

Choose a reason for hiding this comment

holopansel Feb 13, 2023

Choose a reason for hiding this comment

holopansel Feb 15, 2023

Choose a reason for hiding this comment

uklotzde May 13, 2022

Choose a reason for hiding this comment

holopansel Feb 13, 2023

Choose a reason for hiding this comment

uklotzde left a comment

Choose a reason for hiding this comment

uklotzde commented May 13, 2022

holopansel commented May 20, 2022 • edited Loading

Swiftb0y commented Feb 13, 2023

ronso0 commented Feb 13, 2023

holopansel commented Feb 13, 2023

JoergAtGithub commented Feb 15, 2023

holopansel commented Feb 15, 2023

holopansel commented Feb 15, 2023

ronso0 commented Feb 15, 2023

holopansel commented Feb 16, 2023

ronso0 commented Feb 16, 2023

ronso0 commented Feb 16, 2023

holopansel commented Feb 16, 2023

ronso0 commented Feb 16, 2023

holopansel commented Feb 17, 2023 • edited Loading

ronso0 commented Feb 17, 2023

ronso0 commented Feb 17, 2023

JoergAtGithub left a comment

Choose a reason for hiding this comment

holopansel commented Feb 17, 2023

ronso0 commented Feb 17, 2023

JoergAtGithub commented Feb 18, 2023

holopansel commented Feb 19, 2023

ronso0 Feb 22, 2023

Choose a reason for hiding this comment

ronso0 commented Feb 22, 2023

JoergAtGithub commented Feb 22, 2023

JoergAtGithub commented Feb 22, 2023

holopansel commented Feb 23, 2023

holopansel commented May 13, 2022 •

edited by Swiftb0y

Loading

uklotzde May 13, 2022 •

edited

Loading

holopansel commented May 20, 2022 •

edited

Loading

holopansel commented Feb 17, 2023 •

edited

Loading