Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre commit #525

Merged
merged 4 commits into from
Jan 11, 2023
Merged

Fix pre commit #525

merged 4 commits into from
Jan 11, 2023

Conversation

JoergAtGithub
Copy link
Member

Pre-Commit didn't work for me locally on Windows:

1.) When I execute pre-commit on my command line, a dialog pops up, asking for my GitLab credentials - I have no account at GitLab
2.) Python interpreter is not found (same fix as in mixxxdj/mixxx#11004 )

…ersonal user authentication to clone the git repository
… the Shebang in the .py file, which is a Unix only feature)
@daschuer
Copy link
Member

Thank you. There are now CI errors.
Optimize SVG files fails. Is this related to this PR?

@JoergAtGithub
Copy link
Member Author

I did not see this locally - and I did not touch the SVG file. I can't explain this.

@JoergAtGithub JoergAtGithub changed the base branch from 2.3 to main January 8, 2023 19:11
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@daschuer daschuer merged commit 544cdc5 into mixxxdj:main Jan 11, 2023
@Swiftb0y
Copy link
Member

@JoergAtGithub can you open another PR against the 2.3 branch?

@JoergAtGithub JoergAtGithub mentioned this pull request Jan 15, 2023
@JoergAtGithub JoergAtGithub deleted the FixPreCommit branch January 15, 2023 13:04
@JoergAtGithub
Copy link
Member Author

@JoergAtGithub can you open another PR against the 2.3 branch?

I did (PR #529), but with target 2.3 CI fails - as this PR before I retargeted to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants