-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pre commit #525
Fix pre commit #525
Conversation
…ersonal user authentication to clone the git repository
… the Shebang in the .py file, which is a Unix only feature)
Thank you. There are now CI errors. |
I did not see this locally - and I did not touch the SVG file. I can't explain this. |
fdfa038
to
5b6c2b2
Compare
5b6c2b2
to
bda8cb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you.
@JoergAtGithub can you open another PR against the 2.3 branch? |
I did (PR #529), but with target 2.3 CI fails - as this PR before I retargeted to main. |
Pre-Commit didn't work for me locally on Windows:
1.) When I execute pre-commit on my command line, a dialog pops up, asking for my GitLab credentials - I have no account at GitLab
2.) Python interpreter is not found (same fix as in mixxxdj/mixxx#11004 )