Skip to content

Commit

Permalink
Macros: Add todo comments
Browse files Browse the repository at this point in the history
  • Loading branch information
xeruf committed Nov 20, 2021
1 parent 2720c49 commit 21afe4c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/engine/controls/macrocontrol.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ MacroControl::MacroControl(const QString& group, UserSettingsPointer pConfig, in
&MacroControl::slotClear);
}

// FIXME(xeruf) Jumps while paused (e.g. via GotoAndStop) are not properly recorded
// since this function is not called
void MacroControl::process(const double dRate,
mixxx::audio::FramePos currentPosition,
const int iBufferSize) {
Expand Down Expand Up @@ -109,6 +111,8 @@ void MacroControl::process(const double dRate,
}
}

// TODO(xeruf) Verify that all active Macros are fully unloaded and inactive
// before a new track is loading - https://github.com/mixxxdj/mixxx/pull/2989#issuecomment-753465755
void MacroControl::trackLoaded(TrackPointer pNewTrack) {
if (isRecording()) {
if (stopRecording()) {
Expand Down Expand Up @@ -160,6 +164,7 @@ MacroControl::Status MacroControl::getStatus() const {
return Status(m_COStatus.get());
}

// TODO(xeruf) Waveform dimming when running
void MacroControl::setStatus(Status status) {
m_COStatus.forceSet(static_cast<int>(status));
m_COPlay.set(status == Status::Playing ? 1 : 0);
Expand Down
2 changes: 2 additions & 0 deletions src/track/track.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1299,6 +1299,8 @@ bool Track::isDirty() {
if (m_bDirty) {
return true;
}
// FIXME(xeruf) this should be incorporated in the dirty state of the track itself
// but that is non-trivial, since, unlike other track properties, Macros are mutable
for (const MacroPointer& pMacro : qAsConst(m_macros)) {
if (pMacro->isDirty()) {
return true;
Expand Down

0 comments on commit 21afe4c

Please sign in to comment.