Merge pull request #11972 from Holzhaus/warn-on-deprecated-control

Log warning if deprecated control is used
mixxxdj · Sep 14, 2023 · 2975ec5 · 2975ec5
2 parents 42798e9 + fe1b3f7
commit 2975ec5
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/src/control/control.cpp b/src/control/control.cpp
@@ -154,6 +154,16 @@ QSharedPointer<ControlDoublePrivate> ControlDoublePrivate::getControl(
         if (it != s_qCOHash.end()) {
             auto pControl = it.value().lock();
             if (pControl) {
+                auto actualKey = pControl->getKey();
+                if (actualKey != key) {
+                    qWarning()
+                            << "ControlObject accessed via deprecated key"
+                            << key.group << key.item
+                            << "- use"
+                            << actualKey.group << actualKey.item
+                            << "instead";
+                }
+
                 // Control object already exists
                 if (pCreatorCO) {
                     qWarning()