Add comments at the issue locations, that we don't forget to remove -…

…Wno-nan-infinity-disabled when the issue is fixed
mixxxdj · Nov 11, 2024 · 4142e7f · 4142e7f
1 parent 3a58cd0
commit 4142e7f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/test/durationutiltest.cpp b/src/test/durationutiltest.cpp
@@ -115,6 +115,8 @@ TEST_F(DurationUtilTest, formatTime) {
     formatTime("24:00:00.000", 24 * 3600);
     formatTime("24:00:01.000", 24 * 3600 + 1);
     formatTime("25:00:01.000", 25 * 3600 + 1);
+    // If you change the following line, check if it solves #13780,
+    // and allows to remove -Wno-nan-infinity-disabled from the clang-tidy call
     formatTime("?", std::numeric_limits<double>::infinity());
     formatTime("?", -1);
 }

diff --git a/src/test/frametest.cpp b/src/test/frametest.cpp
@@ -18,6 +18,8 @@ TEST_F(FrameTest, TestFramePosValid) {
     // Denormals
     EXPECT_TRUE(mixxx::audio::FramePos(0.0).isValid());
     EXPECT_TRUE(mixxx::audio::FramePos(std::numeric_limits<double>::min() / 2.0).isValid());
+    // If you change the following line, check if it solves #13780,
+    // and allows to remove -Wno-nan-infinity-disabled from the clang-tidy call
     EXPECT_FALSE(mixxx::audio::FramePos(std::numeric_limits<double>::infinity()).isValid());
     // NaN
     EXPECT_FALSE(mixxx::audio::FramePos().isValid());
@@ -53,6 +55,8 @@ TEST_F(FrameTest, TestFramePosEquality) {
     EXPECT_EQ(mixxx::audio::FramePos(),
             mixxx::audio::FramePos(std::numeric_limits<
                     mixxx::audio::FramePos::value_t>::quiet_NaN()));
+    // If you change the following 3 tests, check if it solves #13780,
+    // and allows to remove -Wno-nan-infinity-disabled from the clang-tidy call
     EXPECT_EQ(mixxx::audio::FramePos(),
             mixxx::audio::FramePos(std::numeric_limits<
                     mixxx::audio::FramePos::value_t>::infinity()));