Skip to content

Commit

Permalink
Delete wrong debug assertion
Browse files Browse the repository at this point in the history
...that is triggered when switching between browse views
  • Loading branch information
uklotzde committed Dec 16, 2017
1 parent bc407e6 commit 8670584
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions src/widget/wtracktableview.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1363,11 +1363,13 @@ QList<TrackId> WTrackTableView::getSelectedTrackIds() const {
trackIds.reserve(rows.size());
for (const QModelIndex& row: rows) {
const TrackId trackId = pTrackModel->getTrackId(row);
VERIFY_OR_DEBUG_ASSERT(trackId.isValid()) {
qWarning() << "Skipping invalid track id @" << row;
continue;
if (trackId.isValid()) {
trackIds.append(trackId);
} else {
// This happens in the browse view where only some tracks

This comment has been minimized.

Copy link
@daschuer

daschuer Dec 25, 2017

Member

Why does this happen? Please comment.
Does it happen when we have invalid tracks listed?
I assume that this could probably supprising for a user if actions of invalid tracks are ignored silently.
Did we not list them at all before?

// have an id.
qDebug() << "Skipping row" << row << "with invalid track id";
}
trackIds.append(trackId);
}

return trackIds;
Expand Down

0 comments on commit 8670584

Please sign in to comment.