Return a local copy of m_cuePoints to avaoid a race consition

The QList copy constructor seems to be not thread-safe in case it is not already shared.
mixxxdj · Oct 17, 2022 · a4c9cab · a4c9cab
1 parent e3759aa
commit a4c9cab
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/track/track.h b/src/track/track.h
@@ -263,8 +263,9 @@ class Track : public QObject {
     void removeCue(const CuePointer& pCue);
     void removeCuesOfType(mixxx::CueType);
     QList<CuePointer> getCuePoints() const {
-        // Copying implicitly shared collections is thread-safe
-        return m_cuePoints;
+        const QMutexLocker lock(&m_qMutex);
+        QList<CuePointer> cuePoints = m_cuePoints;
+        return cuePoints;
     }
 
     void setCuePoints(const QList<CuePointer>& cuePoints);