Skip to content

Commit

Permalink
CMake: Get rid of duplicate target_include_directories for Katai
Browse files Browse the repository at this point in the history
When an include directory for a target is marked as PUBLIC, it will also
be added as to all targets that depend on it (i.e. if the target is a
library, all targets that this library is linked to via target_link_libraries
will also have this include directory). Hence, there's no need to set
this include directory twice.
  • Loading branch information
Holzhaus committed Nov 12, 2019
1 parent 11beede commit b17ed12
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1232,9 +1232,8 @@ target_link_libraries(mixxx-lib PUBLIC LAME::LAME)
add_library(Kaitai STATIC EXCLUDE_FROM_ALL
lib/kaitai/kaitaistream.cpp
)
target_include_directories(Kaitai SYSTEM PRIVATE lib/kaitai)
target_include_directories(Kaitai SYSTEM PUBLIC lib/kaitai)
target_compile_definitions(Kaitai PRIVATE KS_STR_ENCODING_NONE)
target_include_directories(mixxx-lib PUBLIC lib/kaitai)
target_link_libraries(mixxx-lib PUBLIC Kaitai)

# For determining MP3 timing offset cases in Rekordbox library feature
Expand Down

0 comments on commit b17ed12

Please sign in to comment.