WSearchLineEdit: don't trigger search when pressing cursor keys

mixxxdj · Feb 20, 2023 · ed10381 · ed10381
1 parent cb02680
commit ed10381
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/src/widget/wsearchlineedit.cpp b/src/widget/wsearchlineedit.cpp
@@ -316,8 +316,9 @@ QString WSearchLineEdit::getSearchText() const {
         if (pCompleter && pEdit && pEdit->hasSelectedText()) {
             if (text.startsWith(pCompleter->completionPrefix()) &&
                     pCompleter->completionPrefix().size() == pEdit->cursorPosition()) {
-                // Search for the entered text until the user has confirmed the
-                // completion by -> or enter
+                // Search for the entered text until the user has accepted the
+                // completion by pressing Enter or changed/deselected the selected
+                // completion text with Right or Left key
                 return pCompleter->completionPrefix();
             }
         }
@@ -387,10 +388,16 @@ void WSearchLineEdit::keyPressEvent(QKeyEvent* keyEvent) {
         }
         break;
     case Qt::Key_Left:
-    case Qt::Key_Right:
+    case Qt::Key_Right: {
+        // Both keys change or clear the selection (suggested completion).
+        // Don't search immediately but let slotTextChanged() engage the debounce timer.
+        QLineEdit* pEdit = lineEdit();
+        DEBUG_ASSERT(pEdit);
+        QString text = pEdit->text();
         QComboBox::keyPressEvent(keyEvent);
-        slotTriggerSearch();
+        slotTextChanged(text);
         return;
+    }
     case Qt::Key_Enter:
     case Qt::Key_Return: {
         if (slotClearSearchIfClearButtonHasFocus()) {