DlgTrackInfoMulti: remove clear(), it's not needed

mixxxdj · May 20, 2024 · ff871eb · ff871eb
1 parent 2aaa433
commit ff871eb
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 20 deletions.
diff --git a/src/library/dlgtrackinfo.cpp b/src/library/dlgtrackinfo.cpp
@@ -294,7 +294,7 @@ void DlgTrackInfo::slotApply() {
 }
 
 void DlgTrackInfo::slotOk() {
-    slotApply();
+    saveTrack();
     clear();
     accept();
 }

diff --git a/src/library/dlgtrackinfomulti.cpp b/src/library/dlgtrackinfomulti.cpp
@@ -290,23 +290,18 @@ void DlgTrackInfoMulti::slotApply() {
 
 void DlgTrackInfoMulti::slotOk() {
     slotApply();
-    clear();
     accept();
 }
 
 void DlgTrackInfoMulti::slotCancel() {
-    clear();
     reject();
 }
 
 void DlgTrackInfoMulti::loadTracks(const QList<TrackPointer>& pTracks) {
-    clear();
-
     if (pTracks.isEmpty()) {
         return;
     }
 
-    m_pLoadedTracks.clear();
     for (const auto& pTrack : pTracks) {
         m_pLoadedTracks.insert(pTrack.get()->getId(), pTrack);
     }
@@ -676,19 +671,6 @@ void DlgTrackInfoMulti::saveTracks() {
     updateFromTracks();
 }
 
-void DlgTrackInfoMulti::clear() {
-    const QSignalBlocker signalBlocker(this);
-
-    disconnectTracksChanged();
-    m_pLoadedTracks.clear();
-    m_trackRecords.clear();
-
-    m_pWStarRating->slotSetRating(0);
-    trackColorDialogSetColorStyleButton(mixxx::RgbColor::nullopt());
-    m_pWCoverArtLabel->loadTrack(TrackPointer());
-    m_pWCoverArtLabel->setCoverArt(CoverInfo(), QPixmap());
-}
-
 void DlgTrackInfoMulti::connectTracksChanged() {
     for (const auto& pTrack : std::as_const(m_pLoadedTracks)) {
         connect(pTrack.get(),

diff --git a/src/library/dlgtrackinfomulti.h b/src/library/dlgtrackinfomulti.h
@@ -65,7 +65,6 @@ class DlgTrackInfoMulti : public QDialog, public Ui::DlgTrackInfoMulti {
     void init();
     void loadTracksInternal(const QList<TrackPointer>& pTracks);
     void saveTracks();
-    void clear();
 
     void connectTracksChanged();
     void disconnectTracksChanged();