waveform text markers not scaled correctly on macOS 11.4

[mixxxbot]

Reported by: foss-4
Date: 2021-06-05T10:01:02Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1930968
Attachments: testlabel.png, cue.png, [more context.png](https://bugs.launchpad.net/bugs/1930968/+attachment/5502602/+files/more context.png), deere.png, [#3954 patch.png](https://bugs.launchpad.net/bugs/1930968/+attachment/5502702/+files/#3954 patch.png)

---

Testing latest 2.3 beta 2.3-beta-4131-g5ae08b96de on macOS 11.4 and noticing track markers are now showing up with increased size.

Is this expected?

[mixxxbot]

Commented by: foss-4
Date: 2021-06-05T10:01:02Z
Attachments: testlabel.png

[mixxxbot]

Commented by: foss-4
Date: 2021-06-05T10:01:20Z
Attachments: cue.png

[mixxxbot]

Commented by: foss-4
Date: 2021-06-05T10:57:14Z
Attachments: [more context.png](https://bugs.launchpad.net/mixxx/+bug/1930968/+attachment/5502602/+files/more context.png)

[mixxxbot]

Commented by: foss-4
Date: 2021-06-05T10:59:40Z
Attachments: deere.png

[mixxxbot]

Commented by: daschuer
Date: 2021-06-05T17:29:38Z

---

Which display scale are you using?
We have recently applied the scale factor to the fonts and makers as well.
See:
#3936

Now we have the same ratio between the skin widgets and the waveform marked.

In general I think they could become a bit smaller.
But we need to check the usability, because they should be readable when moving.

[mixxxbot]

Commented by: foss-4
Date: 2021-06-05T18:00:14Z

---

System Preferences for external monitor the screenshots were taken on are on scaled and the very right setting (more space).

[mixxxbot]

Commented by: foss-4
Date: 2021-06-05T18:03:39Z

---

Looking identical though when mixxx is on macbook monitor. Was unsure what size was expected. No issue personally with having big labels. Feel free to close if intended.

[mixxxbot]

Commented by: ronso0
Date: 2021-06-05T19:18:29Z

---

The screenshot looks like you use 200% scaling for Mixxx.
So, Yes, the text markers are too big, exactly twice the size they shold be.

Appearantly, it's not an issue with Mixxx-internal marker scaling in general since the pixmap markers (Deere > Cue) look okay. It's just the text markers, so I will exlude macOS from font scaling then.

[mixxxbot]

Commented by: ronso0
Date: 2021-06-05T19:20:13Z

---

regresion caused by #3936

[mixxxbot]

Commented by: foss-4
Date: 2021-06-06T10:06:55Z

---

#3954

[mixxxbot]

Commented by: foss-4
Date: 2021-06-06T11:07:31Z
Attachments: [#3954 patch.png](https://bugs.launchpad.net/mixxx/+bug/1930968/+attachment/5502702/+files/#3954 patch.png)

---

2.3-beta-4140-g17d14e93ba
fix verified

ronso0 thanks for taking care of this so swiftly ✨

[mixxxbot]

Issue closed with status Fix Released.