Waveform: always use pixel size and 'Open Sans' for text markers #3954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschuer
approved these changes
Jun 6, 2021
|
This fixed the issue on Ubuntu Bionic and Groovy and does not introduce a regression in Ubuntu Focal. |
|
The QT 5.12 issue that the library font is not scaled by QT_SCREEN_SCALE_FACTORS is not changed by this PR. |
|
Also fixed on Windows10, no matter how I mix app and font scaling. |
|
Also reported to be fixed on macOS by @foss- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waveform text markers now
Please test on
Try different combinations of font scaling, general app scaling (if available, "Make everything Bigger" on Win10 : ) and
export QT_SCALE_FACTORS=...(see Troubleshooting). Also use fractional scaling if available.Then, check if the waveform text markers are always sized 'pleasantly' like in the below screenshots.
Please test at 100% with current 2.3beta first and report if the font size differs noteworthy.