Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotcue default color will be ignored #11260

Closed
Russe opened this issue Feb 8, 2023 · 14 comments
Closed

Hotcue default color will be ignored #11260

Russe opened this issue Feb 8, 2023 · 14 comments

Comments

@Russe
Copy link
Contributor

Russe commented Feb 8, 2023

Bug Description

When setting a hotcue it will always get the yellow/orange color.
I changed the default hotcue color to a different one at Mixxx settings, but this will not solve the issue.
Every time when setting a new hotcue it will get this yellow/orange color.

For testing I removed folder .mixxx with all settings, but this did not solve the issue.
Ass well I tried to remove and install again most recent alpha version, but this did not solve the issue.
As well I tried with different skins, but this did not solve the issue.

Version

2.4.0-alpha-pre (2.4-alpha-1403... (main))

OS

Xubuntu 22.04

@Russe Russe added the bug label Feb 8, 2023
@Swiftb0y
Copy link
Member

Swiftb0y commented Feb 9, 2023

Can you post a screenshot of your Color Preferences?

@Russe
Copy link
Contributor Author

Russe commented Feb 9, 2023

As you can see, default color at preferences is green, but when adding a hotcue it will become orange color.

mixxx-hotcue-colors

@Swiftb0y
Copy link
Member

Swiftb0y commented Feb 9, 2023

Confirmed, I can also reproduce the issue on main. I'll try to find some time to investigate.

@Swiftb0y Swiftb0y added this to the 2.4.0 milestone Mar 30, 2023
@Swiftb0y
Copy link
Member

hey there @Russe. In order to properly debug this, I need the entire git version including the commit hash (the letters and numbers after the last -).

@Swiftb0y
Copy link
Member

Quick note. I can't reproduce the issue with a fresh settings dir. This is a little more complicated than I thought.

@Russe
Copy link
Contributor Author

Russe commented May 14, 2023

Currently I'm using this version where I can reproduce the issue: 2.4.0-alpha-pre (2.4-alpha-1403-gcce89d09f3 (main))
It's also reproducible with a new .mixxx folder and new library.

@Swiftb0y
Copy link
Member

Thank you, I'll try my best to find the cause.

@daschuer
Copy link
Member

I can reproduce the issue with a fresh settings dir.
@Swiftb0y, do you have already an idea for the cause?

@Swiftb0y
Copy link
Member

not yet, I'm trying to bisect but I'm struggling because the branch is so old.

@Swiftb0y
Copy link
Member

Ah I see why I couldn't reproduce it anymore. Coloring "By hotcue number" works, but not when choosing some other static color.

@daschuer
Copy link
Member

I have found the issue. It looks like a wrong merge conflict resolve. I will prepare a PR.

@Swiftb0y
Copy link
Member

Fixed in 2.4 newer. @Russe please test these new versions and reopen this issue if it still occurs.

@Russe
Copy link
Contributor Author

Russe commented May 15, 2023

Thanks for fixing this. As I'm on the road during next weeks I can test new versions later.

@Russe
Copy link
Contributor Author

Russe commented Jul 23, 2023

Sorry for late answering. I updated to 2.4 beta and hotcue default is fixed now.
Thanks a lot for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants