Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting the wrong default cue color. #11554

Merged
merged 5 commits into from
May 15, 2023
Merged

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented May 14, 2023

This PR fixes also the issue that cues are shown with wrong default for a split of a second.

Fixes #11260

This PR fixes also the issue that cues are shown with wrong dafault for a spit of a second in
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put my review suggestions into a PR: daschuer#85

@daschuer
Copy link
Member Author

Done

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I appreciate the team work. Should we merge or do we need a 3rd pair of eyes?

@daschuer
Copy link
Member Author

I think we it is OK to just merge in cases like this.

@Swiftb0y Swiftb0y merged commit ab83bef into mixxxdj:2.4 May 15, 2023
@daschuer
Copy link
Member Author

Thank you :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants