Played checkbox in unchecked state not correctly displayed

[foss-]

Bug Description

The problem is limited to the 2.4. 2.3.6 and 2.5 do display the checkbox as expected.
2.4-beta-283-g695e9f594b
macOS 13.6.1 (intel mac)

2.3.6

2.4 2023-12-10

2.5 2023-12-10

The code in main was touched october 2023: #12050 polite ping @fwcd

see also #10721

Version

2.4-beta-283-g695e9f594b

OS

macOS 13.6.1 (intel mac)

[fwcd]

Do you mean the slightly accentuated top/left border? My guess is that this is some change between Qt 5 and 6 in the way they render checkboxes, which presumably also caused #11908. Since it's only a minor stylistic glitch, I am not sure if it is worth fixing, given that we want to move to Qt 6 anyway. Unless, of course, the fix is trivial and doesn't break the styling on Qt 6.

cc @ronso0

[foss-]

I am fine if you think this is expected for Qt 5. Was slightly surprised as 2.3.6 shows the checkbox as expected and does not use that fake 3D checkbox style 🙈.

Please don't let this delay 2.4 especially since 2.5 looks great.

[ronso0]

Seems to be a special macOS Qt bug.
FWIW on Linux I couldn't reproduce any of the checkbox issues.

@foss- Does it look like that in all skins?
Do it change it you use another system style scheme (don't know how much custmization is possible in macOS), do the checkboxes look like other checkboxes in macOS, e.g. in preferences or other apps?

Just trying to understand what's happening. @fwcd do you also run macOS 13.6.1?

[foss-]

There are no schemes in macOS. System Settings > Appearance allows Light | Dark | Auto along an accent and highlight color, done. But those don't affect the checkbox UI.

2.4-beta-283-g695e9f594b

• Deere
• Shade
• Tango
• LateNight > PaleMoon or Classic

Interestingly only LateNight is affected. This is how the checkbox looks for Deere:

Probably fair to keep it open and let it sit for a while.

[ronso0]

@foss- From the screenshots' size I assume you don't have a Retina display / don't use Retina scaling on the Mixxx screen?
If yes, this is a regression from #12407 (that touched only LateNight)

[foss-]

Hmm - this is a 2017 retina MacBook Pro however I was running Mixxx on an external screen. So you are indeed onto something.

Running Mixxx without external display results in the expected checkbox on the laptop screen.

With a large external 43" 4k monitor the checkbox shows in the unexpected form. Just moving the window is sufficient to make the checkbox change its appearance.

[ronso0]

With a large external 43" 4k monitor the checkbox shows in the unexpected form. Just moving the window is sufficient to make the checkbox change its appearance.

So you just move the window a little, or to the laptop screen?
Are you launching Mixxx on the second display, or on te primary one and then move it to the external one?

However, as long as it only affects the external screen and all other icons are rendered fine we should not do anything IMO.

[foss-]

I move the open window and as soon as I am on the external window the checkbox UI is wrong. Move window back to laptop screen -> checkbox is fine. Doesn't matter on which monitor Mixxx is first opened.
Ok, lets close this and I'll probably move to main, to get this sorted.