-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor WaveformFactory and Pref #13245
Comments
@Swiftb0y let me know if you would like me to take a look at this if you are happy with doing the clean up yourself |
I'm currently ringing for time a little so I don't know if I have the time. I'll try to whip up something later today, If not feel free to take over. |
@acolombier so I spent the day and came up with https://github.com/Swiftb0y/mixxx/tree/refactor/gh13245-waveform-factory%26prefs (doesn't fully build; also currently segfaults on teardown because of 424b1c9 which I haven't found the time to dig into). |
Great! Thanks for your effort. |
WaveformWidgetFactory::findHandle*
const
and use something likeWaveformWidgetFactory::create[*]Waveform
with smart pointersUserConfig
functions whenever applicable and replace verboseset
orget
withsetValue
orgetValue
WaveformWidgetAbstractHandle
and aim to remove it if possiblesrc/waveform/widgets/waveformwidgettype.h
to adopt a similar style than in Refactor/preferences enums #12798This is a dependency for #13226
The text was updated successfully, but these errors were encountered: