single waveformwidget class for all allshader waveform widget types #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…some cleanup in waveformwidgetfactory
This was referenced May 22, 2024
Swiftb0y
reviewed
May 22, 2024
Comment on lines
+165
to
+171
| WaveformWidgetVars WaveformWidget::vars() { | ||
| WaveformWidgetVars result; | ||
| result.m_useGL = true; | ||
| result.m_useGLES = true; | ||
| result.m_useGLSL = true; | ||
| result.m_category = WaveformWidgetCategory::AllShader; | ||
| return result; |
There was a problem hiding this comment.
Suggested change
| WaveformWidgetVars WaveformWidget::vars() { | |
| WaveformWidgetVars result; | |
| result.m_useGL = true; | |
| result.m_useGLES = true; | |
| result.m_useGLSL = true; | |
| result.m_category = WaveformWidgetCategory::AllShader; | |
| return result; | |
| WaveformWidgetVars WaveformWidget::defaultVars() { | |
| return { .m_useGL = true, | |
| .m_useGLES = true, | |
| .m_useGLSL = true, | |
| .m_category = WaveformWidgetCategory::AllShader | |
| }; |
Comment on lines
+235
to
+237
| void addHandle( | ||
| QHash<WaveformWidgetType::Type, QList<WaveformWidgetBackend>>& | ||
| collectedHandles, |
There was a problem hiding this comment.
I don't like the out-parameter here, but we can clean that up some time else.
There was a problem hiding this comment.
I agree, I was thinking to put all this in a class with the QHash as a member. I'll add a TODO so we don't forget about it.
There was a problem hiding this comment.
Just referencing mixxxdj/mixxx#13245 for tracking
|
@acolombier up to you to review / merge :) |
|
@acolombier I think you can merge this already. I will create a follow-up PR with the suggestions from @Swiftb0y when I have a moment. |
acolombier
merged commit 5c3551d
into
acolombier:feat/simplify-waveform-combobox
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a single allshader::WaveformWidget class for all the allshader Waveform widget types.
Note how I automatically deal with adding the slip renderer layers.
I also did some cleanup in WaveformWidgetFactory, some related with / required by this change to use a single allshader::WaveformWidget. I also introduced a struct WaveformWidgetVars, to be used instead of having to add multiple static functions (static bool useGL, etc), but I only use this for the allshader::WaveformWidget for now.