Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LateNight knob notches blend with background for red-green colorblind users #8875

Closed
mixxxbot opened this issue Aug 23, 2022 · 7 comments
Closed
Labels
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: Be-ing
Date: 2017-05-31T07:55:05Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1694624
Attachments: latenight-mixer-colorblind.png


Red looks like brown. See attached screenshot from the deuteranopia simulator in KMag.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2017-05-31T07:55:05Z

@mixxxbot mixxxbot added the bug label Aug 23, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2017-05-31T07:59:58Z
Attachments: latenight-mixer-colorblind.png

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2017-06-01T19:22:42Z


IMHO we should be sure that our new default skin "fits all". For the other skins we may consider to do a very optimized for any visual disablements in one case, or just optimized for high fashion.
We should be clear about which skin solves which requirements. So that we later are aware of that and not destroy these features by accident.

How does Deere work for visual disablements in general?

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2017-06-02T03:01:21Z


We should not ship skins that are impractical for color blind users. It is not okay to only have one acceptable skin for color blind users and multiple choices for others. Fortunately, I do not think very much needs to be changed in any skin. In LateNight, it is the same red color used throughout. In Deere, I think it is only the red knob notches and the red metaknob link inversion button that do not work well. In Tango, the problem is also the red used in the skin. If we can figure out a different color instead of red, I think it will be okay. I'll try different shades of orange.

@mixxxbot
Copy link
Collaborator Author

Commented by: kazakore
Date: 2018-03-08T11:25:07Z


I don't think that's too bad, you have the contrast difference already so even in monochrome you would be able to see in the indentations. I could suggest maying the brighter bit at the end of the line on the knobs just a little bit bigger or brighter in colour but that's about it....

It's also acceptable to have on High Contrast skin, which would be perfectly viewable in monochrome/b&w, which I think it's worth checking for the most common red/green colour-blindness on the rest I'm not sure you need to make sure all of them are find right down to the contrast/brightness only level.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-07-05T11:49:22Z


in #2913 all knobs are improved, finally.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.3.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant