LateNight :: follow-up fixes / update

[ronso0]

here I collect fixes and improvements for the recent LateNight update.

General

• add missing tooltips
• fix cropped Stars rating in decks on MacOS
• fix skin defaults https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/loop.20and.20beatjump.20sizes.20in.20LateNight.20compact.20decks
• add controller_focus indicator [FxRack1_FxUnitN],controller_input_active
• restore loop labels on waveforms
• adjust initial waveform split size
• improve splitter handle discoverability
• tweak launch screen & toolbar logo
• add Broadcast icon, rename to ON AIR
• fix some warnings https://bugs.launchpad.net/mixxx/+bug/1884802
• fix (deck) 'Star rating off by one star' on MacOS, https://bugs.launchpad.net/mixxx/+bug/1870909

Classic

• fix crossfader scale, update knob
• more contrast in fx mixmode icons
• add indentations in skin settings

PaleMoon

• unique beatloop icons
• improve spinny mask with cover art visible
• fix cropped effect name in WEffectSelectors
• make BPM tap button more discoverable with hover effect
• make track context menu more discoverable with hover effect
• equalize brightness of dark standalone VU meters

Nice to have

• tweak hotcue icons for bright/dim hotcue colors (after Skins: allow custom brightness threshold for hotcue colors #2928 )
• show track color in decks (after WTrackWidgetGroup with track color background #2834)
• add Sync and key match overlay to mini decks ?
• fix style of open Effect selector on Windows

[uklotzde]

Retarget for 2.3?

[ronso0]

..of course, thx!

[Holzhaus]

Cool. When you're done with it, can you write blogpost the showcases the massive improvements you made to our new default skin for mixxxdj/website#77?

PaleMoon: unique beatloop icons

can you make then round or do you have something different in mind?

[Holzhaus]

Another thing: can we make the WCueMenuPopup use the same styles you use for hotcue buttons?

[ronso0]

I can try that, sure.
I have difficulties with the current color buttons anyway: with that palette and style it's never WYSIWYG, there always seems to be some overlay that makes the colors more pale.

[ronso0]

When you're done with it, can you write blogpost the showcases the massive improvements you made to our new default skin for mixxxdj/website#77?

Yep, I'm already sketching the post.

can you make then round or do you have something different in mind?

I want to get away from the edged look, yes. some slight rounding will be sufficient making the icons blend in with the rest of PaleMoon.

[JoergAtGithub]

The new FX meta knob position makes it much easier, to distinguish meta and super knobs!

[ronso0]

great! it's the old position, though. toggle & fx selector next to each other was an experiment that failed..

[ronso0]

I added the Fx focus bar (underline looks better but wasn't that obvious IMO)
So far I think that works best and I'll test it in tonight's session :)

PaleMoon

Classic

[ronso0]

Besides small tweaks, on of the last changes here was to improve the popups (context menus, Cue menu, color picker).
If there are no objections I suggest we merge this now.

[Holzhaus]

LGTM, thank you very much.

[foss-]

Anything blocking a merge here?

[uklotzde]

@Holzhaus I am assuming that you forgot to merge this PR after approval? LGTM, too

[foss-]

Testing 2.4.0-alpha-pre (build master r7522) and stars in deck view are now cut off and moved one star to the right, meaning only four of the five stars are shown on deck. Mouse behavior in deck for star rating is still missaligned, i.e. mouse is to the left one star.

[ronso0]

I have no idea why that simple layout is screwed on macOS.
I created a branch with some debug colors so we can figure out what's wrong. The PR for testing/discussion is ronso0#10