-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pioneer DDJ-400: make Beat FX section more intuitive #10912
Pioneer DDJ-400: make Beat FX section more intuitive #10912
Conversation
This patch makes the mapping of the Beat FX section slightly more intuitive: - Beat < (LEFT) and Beat > (RIGHT) buttons now cycle through the focus of the three Effects in Effect Unit 1 leftward and rightward, respectively. - FX SELECT v (DOWN) and FX SELECT v +SHIFT (UP) buttons now select the next and previous effect entry for the focused Effect, respectively. This is more in line with the button names and the Mixxx interface. Based on the work proposed in #4662.
This PR is marked as stale because it has been open 90 days with no activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes mostly make sense. Sorry for neglecting this PR for so long.
I also have to ask you to sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future. Thank you. |
✔️ I have signed the Mixxx Contributor Agreement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, waiting for CI
Great! Force-pushed to fix the code style issues. |
Thank you |
This patch makes the mapping of the Beat FX section on the Pioneer DDJ-400 slightly more intuitive:
Beat <
(LEFT) andBeat >
(RIGHT) buttons now cycle through the focus of the three Effects in Effect Unit 1 leftward and rightward, respectively.FX SELECT v
(DOWN) andFX SELECT v
+SHIFT
(UP) buttons now select the next and previous effect entry for the focused Effect, respectively.This is more in line with the controller's button names and the Mixxx interface.
Has been tested on my own controller (with the latest firmware) using Mixxx 2.3 to work as expected.
Based on the work proposed in #4662. Changes to the Mixxx manual proposed in mixxxdj/manual#519.