Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pioneer DDJ-400: make Beat FX section more intuitive #10912

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Pioneer DDJ-400: make Beat FX section more intuitive #10912

merged 2 commits into from
Mar 20, 2023

Conversation

tiesjan
Copy link
Contributor

@tiesjan tiesjan commented Sep 24, 2022

This patch makes the mapping of the Beat FX section on the Pioneer DDJ-400 slightly more intuitive:

  • Beat < (LEFT) and Beat > (RIGHT) buttons now cycle through the focus of the three Effects in Effect Unit 1 leftward and rightward, respectively.
  • FX SELECT v (DOWN) and FX SELECT v +SHIFT (UP) buttons now select the next and previous effect entry for the focused Effect, respectively.

This is more in line with the controller's button names and the Mixxx interface.

Has been tested on my own controller (with the latest firmware) using Mixxx 2.3 to work as expected.

Based on the work proposed in #4662. Changes to the Mixxx manual proposed in mixxxdj/manual#519.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This patch makes the mapping of the Beat FX section slightly more
intuitive:
- Beat < (LEFT) and Beat > (RIGHT) buttons now cycle through the focus
  of the three Effects in Effect Unit 1 leftward and rightward,
  respectively.
- FX SELECT v (DOWN) and FX SELECT v +SHIFT (UP) buttons now select
  the next and previous effect entry for the focused Effect,
  respectively.

This is more in line with the button names and the Mixxx interface.

Based on the work proposed in #4662.
@github-actions
Copy link

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Jan 27, 2023
@daschuer daschuer added needs review and removed stale Stale issues that haven't been updated for a long time. labels Feb 5, 2023
@daschuer daschuer removed this from the 2.3.4 milestone Feb 23, 2023
@tiesjan
Copy link
Contributor Author

tiesjan commented Mar 20, 2023

@ronso0 @daschuer This was originally planned for 2.3.4, but (understandably) left out as a non-blocking issue. Would it be possible to add it to 2.3.5? That would be much appreciated. 🙂

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes mostly make sense. Sorry for neglecting this PR for so long.

res/controllers/Pioneer-DDJ-400.midi.xml Show resolved Hide resolved
@Swiftb0y
Copy link
Member

I also have to ask you to sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future. Thank you.

@tiesjan
Copy link
Contributor Author

tiesjan commented Mar 20, 2023

✔️ I have signed the Mixxx Contributor Agreement.

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, waiting for CI

@tiesjan
Copy link
Contributor Author

tiesjan commented Mar 20, 2023

Great! Force-pushed to fix the code style issues.

@Swiftb0y Swiftb0y added changelog This PR should be included in the changelog and removed needs review labels Mar 20, 2023
@Swiftb0y
Copy link
Member

Thank you

@Swiftb0y Swiftb0y merged commit c3e28a6 into mixxxdj:2.3 Mar 20, 2023
@daschuer daschuer added this to the 2.3.5 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog This PR should be included in the changelog controller mappings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants