-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rate_ratio for track timing display #10916
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think this is a bug-fix and can go to 2.3
can you rebase it?
can do |
3dec8c0
to
0a33a87
Compare
There is a pre-commit issue the other CI failures are hopfully solved with #10904 |
this all good? |
There is still a code style issue. Can you fix it? |
oh I see. fixed |
I fixed the style issue and now it wants to put it back the way it was before? |
I the original version, there was a leading / Do you have pre-commit installed, I wonder why this has slipped through. |
precommit is broken on my machine and I have been unable to fix it:
|
This prevents wild numbers from appearing during scratching under vinyl control.
ah it's an ubuntu / python issue https://stackoverflow.com/questions/72159827/how-to-solve-pre-commit-asserttion-error-on-ubuntu-22-04 |
@daschuer looks good finally! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
This prevents wild numbers from appearing during scratching under vinyl control.
(Without this, the track time can appear as extremely long or extremely short. The vinyl control code manipulates the rate_ratio value so that it stays within reasonable boundaries).