Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller mapping table: show readable/translated strings for script bindings #11139

Merged
merged 3 commits into from
Jan 4, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Dec 20, 2022

... and other bindings which don't have a description (yet). (very old TODO from #3177

this PR / before:
midi-table-translate

This started as a rather aesthetic fix, but I also stumbled across some inefficencies and fixed those:

  • add a dedicated addLibraryControl() functon to ControlPickerMenu
  • create only one ControlPickerMenu instance per controller (DlgPrefController) and use that for the I/O tables and the Learning Wizard

@ronso0 ronso0 marked this pull request as draft December 21, 2022 00:13
@ronso0 ronso0 force-pushed the mapping-table-translate branch 2 times, most recently from 5697c46 to 6db02ed Compare December 21, 2022 00:49
@ronso0 ronso0 marked this pull request as ready for review December 21, 2022 01:50
@ronso0
Copy link
Member Author

ronso0 commented Dec 21, 2022

I'm also missing a searchbar like in developer tools #11140
Guess this will happen in a separate PR

@ronso0 ronso0 force-pushed the mapping-table-translate branch from 6db02ed to 065397d Compare December 28, 2022 01:07
@github-actions github-actions bot added the skins label Dec 28, 2022
@ronso0 ronso0 changed the base branch from main to 2.3 December 28, 2022 01:08
@ronso0
Copy link
Member Author

ronso0 commented Jan 3, 2023

I'm also missing a searchbar like in developer tools #11140 Guess this will happen in a separate PR

#11165

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit 0ac7938 into mixxxdj:2.3 Jan 4, 2023
@daschuer daschuer added this to the 2.3.4 milestone Jan 4, 2023
@daschuer daschuer added the changelog This PR should be included in the changelog label Jan 4, 2023
@ronso0 ronso0 deleted the mapping-table-translate branch January 4, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog This PR should be included in the changelog controller mappings preferences skins ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants