Icon update #1119

daschuer · 2017-01-13T21:50:45Z

I have updated some icons to be more significant and not ambigious for future feature enhancements.
See commits.
I have also renamed the Library treeview entry to Tracks since all is finally in the library.

I hope that this will help to avoid the confusion between Library and Browse.

I would also like to rename the browse feature to something more significant since Browse can be anything. Do you have an idea?

daschuer · 2017-01-13T21:53:04Z

unfortunately this removes the color transition from the icons. @esbrandt: what is the receipt for the transition?

Be-ing · 2017-01-13T23:14:35Z

LGTM!

These icons should be vectorized. That does not need to be fixed right now. I have opened a bug to track it.

rryan · 2017-01-13T23:33:12Z

Nice, @daschuer did you draw these by hand? If not, is any of the source material copyright?

ferranpujolcamins · 2017-01-13T23:52:23Z

New name for Browse: what about "HDD", "system folders", or something like this, that references the fact that you are looking at whats in the harddrive as is?

…

On 14 Jan 2017 12:33 a.m., "RJ Skerry-Ryan" ***@***.***> wrote: Nice, @daschuer <https://github.com/daschuer> did you draw these by hand? If not, is any of the source material copyright? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1119 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGIcTxiqeaKYFa4SVIXWABl5eLdIy_H-ks5rSAm5gaJpZM4LjWTQ> .

daschuer · 2017-01-13T23:56:54Z

The musical note and the computer are from the gnome high contrast theme with LGPL 2.1
The Interface icon is my own work.
The iTunes and tractor icons are redrawn from original icons found on their websites.

Be-ing · 2017-01-14T00:05:39Z

New name for Browse: what about "HDD", "system folders", or something like this, that references the fact that you are looking at whats in the harddrive as is?

I think "Files" or "File system" would work better.

daschuer · 2017-01-14T00:05:58Z

New name for Browse: what about "HDD", "system folders", or something like this, that references the fact that you are looking at whats in the harddrive as is?

"System Folders" sounds nice. Does this cover also implies jump drives?
"HDD" might be too trecky, maybe unroll HDD to "Drives"

Gnome used the term "Places" but hat will probably only be understandable by Linux users.

Any other votes?

daschuer · 2017-01-14T00:09:17Z

Yes "File system", but that might confuse windows users who are thinking in "Drive Letters".

Be-ing · 2017-01-14T00:13:37Z

Yes "File system", but that might confuse windows users who are thinking in "Drive Letters".

I'm confused how it would be confusing. How does the feature behave on Windows? I'm guessing it shows the C drive as the root of the file system tree?

daschuer · 2017-01-14T00:24:10Z

On Linux we have

Quick links
Jump Drives
/ (root folder of file system)

On windows we have

Quick links
Devices
** C:
** D:

If we agree "File system" is not confusing we can go for it.

Be-ing · 2017-01-14T00:43:51Z

I think "File system" would work for Windows too. It wouldn't be quite as clear for Windows, but I think it's the best option proposed so far. Any other opinions?

rryan · 2017-01-14T01:03:41Z

"File system" seems too technical to me, what do you think of:

File Explorer
Explorer
My Computer
Computer

"Files" also sounds good to me, and is short and parallel to "Tracks".

Be-ing · 2017-01-14T01:24:14Z

"Computer" is clear and works well with Windows terminology. It also matches the new icon.

Be-ing · 2017-01-14T01:27:16Z

The musical note and the computer are from the gnome high contrast theme with LGPL 2.1

This should be acknowledged somewhere.

Be-ing · 2017-01-14T01:31:48Z

Rename res/images/library/ic_library_library.png to res/images/library/ic_library_tracks.png. Also rename the browse icon file for whatever new name we decide.

daschuer · 2017-01-14T11:54:01Z

Windows 7 uses "Computer" Windows 10 uses "This PC" Mac OS, just "MAC", Linux has the "Computer://" place where the Icon is taken from.
How about just hit the Middle of windows 10 and 7: "This Computer" since this computer is a MAC on a MAC, it fits also there ;-)

…for a search feature.

daschuer · 2017-01-14T14:01:18Z

OK, now we have "This Computer" and polished icons with color gradients.

One day, we should rename the C++ classes as well, but I like to postpone this to avoid conflicts and hard to track diffs, when merging the the new library layout.

Be-ing · 2017-01-14T16:19:17Z

How about just hit the Middle of windows 10 and 7

IMO "This Computer" feels kinda weird because it is a middle ground that no other system uses exactly. I think just "Computer" works better.

rryan · 2017-01-14T21:29:04Z

👍 to "Computer" as well

Be-ing · 2017-01-14T23:12:47Z

Can we distribute LGPL icons in the Mac App Store? I think the copyright should be acknowledged in the LICENSE file. It has been a long time since I read the LGPL 2.1. Do we need to distribute the full text of that license?

timrae · 2017-01-15T01:55:44Z

@daschuer
Do have svg's for all of these icons? If you already have them it definitely make sense to add them to the source tree now, rather than hunting for them later.

daschuer · 2017-01-15T08:41:18Z

Sorry, no. That was just pixel shifting in Gimp

daschuer · 2017-01-15T08:45:33Z

LGPL should be no problem for Apple. I have just found that:
https://forums.developer.apple.com/thread/27709
I think if this would be not allowed, we have a problem with the whole Qt library under LGPL

ferranpujolcamins · 2017-01-15T14:08:38Z

+1 to computer :) On 15 Jan 2017 9:45 a.m., "Daniel Schürmann" <notifications@github.com> wrote: LGPL should be no problem for Apple. I have just found that: https://forums.developer.apple.com/thread/27709 I think if this would be not allowed, we have a problem with the whole Qt library under LGPL — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1119 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGIcT1M-Cl6trzFo2CzII9xez92boSO7ks5rSdyvgaJpZM4LjWTQ> .

esbrandt · 2017-01-15T17:24:35Z

unfortunately this removes the color transition from the icons. @esbrandt: what is the receipt for the transition?

@daschuer
sorry for being late. Moved recently and RL happened.
The icon templates are as always in https://github.com/mixxxdj/mixxx/blob/master/res/images/templates/ic_template_library_and_preferences.svg

Multi layered inkscape template, incl. filter settings for the overlays used. If the icons change , i´d love to see the template updated as well.

EDIT: The icons are public domain, as stated in the templates metadata.

daschuer · 2017-01-22T00:08:33Z

Sorry, for now I have no svg versions of the new icons so I cannot update ic_template_library_and_preferences.svg

daschuer · 2017-01-22T00:10:06Z

I think we can merge now. Icon tweaking towards svg can be done in a separate PR.

daschuer mentioned this pull request Jan 13, 2017

Library Layout Redesign Single pane #1117

Closed

11 tasks

daschuer added 6 commits January 14, 2017 13:14

Use a real user preferences icon instead of a computer icon

9a39be9

change library icon to music icon

86f5b9d

update itunes icon

a03c9bd

Replace lens icon for browse with a comuter icon to free up the lens …

025054a

…for a search feature.

Update Traktor icon

1348d7e

Rename Library tree view entry to Tracks, since amost all is library

89383c4

daschuer force-pushed the icon_update branch from 92630bb to 89383c4 Compare January 14, 2017 12:38

daschuer added 3 commits January 14, 2017 14:46

Rename Browse to "This Computer"

2a164cf

reanamed browse icon to this_comuter icon, reference the LGPL 2.1 source

3e186d6

Renamed library icon to tracks icon and reference the LGPL 2.1 source

8f5a168

Strip "This" from "Computer"

8f44487

daschuer merged commit 43efad8 into mixxxdj:master Jan 22, 2017

daschuer deleted the icon_update branch September 7, 2021 21:06

mixxxbot mentioned this pull request Aug 23, 2022

Update Library icons #8759

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Icon update #1119

Icon update #1119

daschuer commented Jan 13, 2017

daschuer commented Jan 13, 2017

Be-ing commented Jan 13, 2017

rryan commented Jan 13, 2017

ferranpujolcamins commented Jan 13, 2017 via email

daschuer commented Jan 13, 2017

Be-ing commented Jan 14, 2017

daschuer commented Jan 14, 2017 •

edited

Loading

daschuer commented Jan 14, 2017

Be-ing commented Jan 14, 2017

daschuer commented Jan 14, 2017

Be-ing commented Jan 14, 2017 •

edited

Loading

rryan commented Jan 14, 2017

Be-ing commented Jan 14, 2017 •

edited

Loading

Be-ing commented Jan 14, 2017

Be-ing commented Jan 14, 2017

daschuer commented Jan 14, 2017

daschuer commented Jan 14, 2017

Be-ing commented Jan 14, 2017

rryan commented Jan 14, 2017

Be-ing commented Jan 14, 2017

timrae commented Jan 15, 2017

daschuer commented Jan 15, 2017

daschuer commented Jan 15, 2017

ferranpujolcamins commented Jan 15, 2017 via email

esbrandt commented Jan 15, 2017 •

edited

Loading

daschuer commented Jan 22, 2017

daschuer commented Jan 22, 2017

Icon update #1119

Icon update #1119

Conversation

daschuer commented Jan 13, 2017

daschuer commented Jan 13, 2017

Be-ing commented Jan 13, 2017

rryan commented Jan 13, 2017

ferranpujolcamins commented Jan 13, 2017 via email

daschuer commented Jan 13, 2017

Be-ing commented Jan 14, 2017

daschuer commented Jan 14, 2017 • edited Loading

daschuer commented Jan 14, 2017

Be-ing commented Jan 14, 2017

daschuer commented Jan 14, 2017

Be-ing commented Jan 14, 2017 • edited Loading

rryan commented Jan 14, 2017

Be-ing commented Jan 14, 2017 • edited Loading

Be-ing commented Jan 14, 2017

Be-ing commented Jan 14, 2017

daschuer commented Jan 14, 2017

daschuer commented Jan 14, 2017

Be-ing commented Jan 14, 2017

rryan commented Jan 14, 2017

Be-ing commented Jan 14, 2017

timrae commented Jan 15, 2017

daschuer commented Jan 15, 2017

daschuer commented Jan 15, 2017

ferranpujolcamins commented Jan 15, 2017 via email

esbrandt commented Jan 15, 2017 • edited Loading

daschuer commented Jan 22, 2017

daschuer commented Jan 22, 2017

daschuer commented Jan 14, 2017 •

edited

Loading

Be-ing commented Jan 14, 2017 •

edited

Loading

Be-ing commented Jan 14, 2017 •

edited

Loading

esbrandt commented Jan 15, 2017 •

edited

Loading