Set minimumWidth of WLabel according to the content's maximum possible width

[daschuer]

This fixes the wiggling off the knob position during adjusting the value.

A regression caused by the switch between value and label.

[ronso0]

LGTM, thanks for the fixup!

Just a question, and please remove the debug output (--amend)

[ronso0]

This screws up the label alignment in Tango and LateNight, though by looking at the Shade knobs xml I discovered how to simplify the Tango/LateNight knob templates.
fix: d639dad

[daschuer]

Re-implementing the sizeHint() Function did finally the trick. Please test again.

[ronso0]

Unfortunately it's not yet working as desired, and I couldn't figure why, yet.
I tried Graphic Eq in Shade and the label shrinks when it switches to show the value.

[ronso0]

I guess the minimumSizeHint doesn't consider the padding.
If I remove the padding the label is static

           padding-left: 3px;
           padding-right: 3px;

https://github.com/mixxxdj/mixxx/pull/11194/files#diff-e1924755bc957e48039a69bcc6c083ed94ae7d4570ef7f317595d370fd3ba5fbR26-R27

However, this is what happens:

• start Mixxx with Shade, fx section is hidden, Graphic EQ is unit1, slot2
• show fx
  
• start to drag a parameter label, or reload the effect:
  the entire knob container shrinks in width:
  
  SizeHint for a specific label has changed.

[ronso0]

Suggested change

	m_widthHint = metrics.size(0, m_longText).width() + frameWidth();
	QString elidedText = metrics.elidedText(m_longText, m_elideMode, width() - frameWidth());
	m_widthHint = metrics.size(0, m_longText).width() + 2 * frameWidth();
	QString elidedText = metrics.elidedText(m_longText, m_elideMode, width() - 2 * frameWidth());

[ronso0]

I think that was it.
At least now the size doesn't change anymore...

edit maybe add a comment that frameWidth() is the sum of margin, padding, border from stylesheets?

Though I think we should try to figure why the label shrinks when parameters are swapped.

[ronso0]

let's rename optimumWidth to valueWidth and

Suggested change

	optimumWidth = math_max(
	optimumWidth,
	metrics.size(0, m_text).width());
	m_widthHint = optimumWidth;
	int optimumWidth = math_max(
	valueWidth,
	metrics.size(0, m_text).width());
	m_widthHint = optimumWidth + 2 * frameWidth();

and remove the debug ouput below

[ronso0]

with this the labels are okay, besides the fact that they are initially (before swapping parameters) expanded compared to 2.4

[daschuer]

Thank you for the good testing. For me it is working now. Also after parameter swapping.

[ronso0]

Yes, it works now.

It's just that something 'broke' the initial view in Shade, compared to 2.4:
initial view:

swapped parameters:

I think this actually looks better, but users may be confused / disappointed by the condensed view after the swap.
Though tbh I don't care too much about it. Since the other skins still work great this is ready.
If you're motivated to debug this we can wait, otherwise I'll merge it. Just let me know how you prefer it.

[ronso0]

@daschuer Ignore this "good"/harmless regression, or investiagte once more?

[daschuer]

Let's just merge this. It is IMHO good enough.