Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serato): Fix resetting track colors on metadata reimport #11217

Merged
merged 2 commits into from
Jan 28, 2023

Commits on Jan 25, 2023

  1. fix(serato): Fix resetting track colors on metadata reimport

    When metadata for a file without Serato tags is reimported, the track
    color is reset. This happens, because there is currently no way to
    distinguish the case where no track color is set because the file does
    not contain any Serato tags from the case where the file contains Serato
    tags and the track color has been set to "no color" in Serato (i.e. the
    stored color value is `0xFFFFFF`.
    
    This fixes the issue by replacing the `RgbColor::optional_t` value with
    a `std::optional<RgbColor::optional_t>` to separate the 3 cases:
    
    1. If the outer optional is `nullopt` , there is no track color present in
      the tags.
    2. If the inner optional is `nullopt`, there is a track color present in
      the tags, and that color is "no color".
    3. If the inner option holds a value, there is a track color with that
       RGB color value present in the tags.
    
    Fixes mixxxdj#11213.
    Holzhaus committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    f033359 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. Configuration menu
    Copy the full SHA
    50c54ce View commit details
    Browse the repository at this point in the history